From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Q32-0003Kw-Cd for qemu-devel@nongnu.org; Tue, 07 Jan 2014 01:22:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0Q2w-0007Ns-DG for qemu-devel@nongnu.org; Tue, 07 Jan 2014 01:21:56 -0500 Received: from [222.73.24.84] (port=43143 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Q2w-0007Nd-2H for qemu-devel@nongnu.org; Tue, 07 Jan 2014 01:21:50 -0500 Message-ID: <52CB9B70.6030005@cn.fujitsu.com> Date: Tue, 07 Jan 2014 14:15:12 +0800 From: Qiao Nuohan MIME-Version: 1.0 References: <1388906864-1083-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1388906864-1083-4-git-send-email-qiaonuohan@cn.fujitsu.com> <52CAF223.8090408@redhat.com> In-Reply-To: <52CAF223.8090408@redhat.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed Subject: Re: [Qemu-devel] [PATCH v6 03/11] dump: Add API to write vmcore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, anderson@redhat.com, akong@redhat.com, afaerber@suse.de On 01/07/2014 02:12 AM, Laszlo Ersek wrote: >> @@ -726,6 +726,34 @@ static int write_end_flat_header(int fd) >> > return 0; >> > } >> > >> > +static int write_buffer(int fd, bool flag_flatten, off_t offset, void *buf, >> > + size_t size) >> > +{ > You might have wanted to const-qualify "*buf" here, but it certainly > doesn't warrant a respin. Acked, I will reflect it in later version. -- Regards Qiao Nuohan