From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Q34-0003Lo-17 for qemu-devel@nongnu.org; Tue, 07 Jan 2014 01:22:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0Q2x-0007O7-EK for qemu-devel@nongnu.org; Tue, 07 Jan 2014 01:21:57 -0500 Received: from [222.73.24.84] (port=43143 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Q2x-0007Nd-34 for qemu-devel@nongnu.org; Tue, 07 Jan 2014 01:21:51 -0500 Message-ID: <52CB9BF5.4010604@cn.fujitsu.com> Date: Tue, 07 Jan 2014 14:17:25 +0800 From: Qiao Nuohan MIME-Version: 1.0 References: <1388906864-1083-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1388906864-1083-5-git-send-email-qiaonuohan@cn.fujitsu.com> <52CAF9E9.9080706@redhat.com> In-Reply-To: <52CAF9E9.9080706@redhat.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed Subject: Re: [Qemu-devel] [PATCH v6 04/11] dump: Add API to write elf notes to buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, anderson@redhat.com, akong@redhat.com, afaerber@suse.de On 01/07/2014 02:46 AM, Laszlo Ersek wrote: >> static int dump_cleanup(DumpState *s) >> > @@ -754,6 +757,22 @@ static int write_buffer(int fd, bool flag_flatten, off_t offset, void *buf, >> > return 0; >> > } >> > >> > +static int buf_write_note(void *buf, size_t size, void *opaque) >> > +{ > "const void *buf" would have been more "elegant". > >> > + DumpState *s = opaque; >> > + >> > + /* note_buf is not enough */ >> > + if (s->note_buf_offset + size> s->note_size) { >> > + return -1; >> > + } >> > + >> > + memcpy(s->note_buf + s->note_buf_offset, buf, size); > Giving type "uint8_t" to "*note_buf" would have been preferable. > Addition to a pointer-to-void is a constraint violation in standard C > ("... operand shall be a pointer to an object type ..."), ie. it's a gcc > extension here, but I guess we can live with it. > > Using s->note_size as limit seems correct. > Acked. -- Regards Qiao Nuohan