From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0QDe-0007UM-A2 for qemu-devel@nongnu.org; Tue, 07 Jan 2014 01:32:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0QDZ-00026a-Ok for qemu-devel@nongnu.org; Tue, 07 Jan 2014 01:32:54 -0500 Received: from [222.73.24.84] (port=60067 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0QDZ-00026G-DV for qemu-devel@nongnu.org; Tue, 07 Jan 2014 01:32:49 -0500 Message-ID: <52CB9F78.3050001@cn.fujitsu.com> Date: Tue, 07 Jan 2014 14:32:24 +0800 From: Qiao Nuohan MIME-Version: 1.0 References: <1388906864-1083-1-git-send-email-qiaonuohan@cn.fujitsu.com> In-Reply-To: <1388906864-1083-1-git-send-email-qiaonuohan@cn.fujitsu.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Subject: Re: [Qemu-devel] [PATCH v6 00/11] Make 'dump-guest-memory' dump in kdump-compressed format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: lcapitulino@redhat.com, eblake@redhat.com, lersek@redhat.com Cc: stefanha@gmail.com, qemu-devel@nongnu.org, Qiao Nuohan , kumagai-atsushi@mxc.nes.nec.co.jp, anderson@redhat.com, akong@redhat.com, afaerber@suse.de Hello Eric, Luiz and Laszlo, What do you think about my series? And I have add the light-weight introspection in the last patch, do you have some comments on it? On 01/05/2014 03:27 PM, Qiao Nuohan wrote: > Hi, all > > The last version is here: > http://lists.nongnu.org/archive/html/qemu-devel/2013-07/msg01376.html > > Command 'dump-guest-memory' was introduced to dump guest's memory. But the > vmcore's format is only elf32 or elf64. The message is here: > http://lists.gnu.org/archive/html/qemu-devel/2012-04/msg03379.html > > Compared with migration, the missing of compression feature means regression > to 'dump-guest-memory'. So we post these patches to make 'dump-guest-memory' be > able to dump guest's in kdump-compressed format. Then vmcore can be much > smaller, and easily to be delivered. > > The kdump-compressed format is *linux specific* *linux standard* crash dump > format used in kdump framework. The kdump-compressed format is readable only > with the crash utility, and it can be smaller than the ELF format because of > the compression support. To get more detailed information about > kdump-compressed format, please refer to the following URL: > http://sourceforge.net/projects/makedumpfile/ > > Note, similar to 'dump-guest-memory': > 1. The guest should be x86 or x86_64. The other arch is not supported now. > 2. If the OS is in the second kernel, gdb may not work well, and crash can > work by specifying '--machdep phys_addr=xxx' in the command line. The > reason is that the second kernel will update the page table, and we can > not get the page table for the first kernel. > 3. The cpu's state is stored in QEMU note. > 4. The vmcore are able to be compressed with zlib, lzo or snappy. zlib is > available by default, and option '--enable-lzo' or '--enable-snappy' > should be specified with 'configure' to make lzo or snappy available. > > Changelog: > Changes from v5 to v6: > 1. add run-time check for compression format(lzo/snappy) > 2. address Stefan's comments about reusing code and coding style > 3. update the version of kdump-compressed format to 6th > 4. resplit the patches > 5. Add 'query-dump-guest-memory-capability' command > > Changes from v4 to v5: > 1. using flatten format to avoid using temporary files according to Stefan's > comments > 2. Address Andreas's comments about coding style > > Changes from v3 to v4: > 1. change to avoid conflict with Andreas's patches > 2. rebase > > Changes from v2 to v3: > 1. Address Eric's comment > > Changes from v1 to v2: > 1. Address Eric& Daniel's comment: fix manner of string copy. > 2. Address Eric's comment: replace reinventing new constants by using the > ready-made ones accoring. > 3. Address Andreas's comment: remove useless include. > > Qiao Nuohan (11): > dump: Add argument to write_elfxx_notes > dump: Add API to write header of flatten format > dump: Add API to write vmcore > dump: Add API to write elf notes to buffer > dump: add support for lzo/snappy > dump: add API to write dump header > dump: Add API to write dump_bitmap > dump: Add APIs to operate DataCache > dump: Add API to write dump pages > dump: Make kdump-compressed format available for 'dump-guest-memory' > Add 'query-dump-guest-memory-capability' command > > configure | 50 +++ > dump.c | 929 ++++++++++++++++++++++++++++++++++++++++++++++++- > hmp-commands.hx | 12 +- > hmp.c | 23 ++- > include/sysemu/dump.h | 138 ++++++++ > qapi-schema.json | 35 ++- > qmp-commands.hx | 13 +- > 7 files changed, 1178 insertions(+), 22 deletions(-) > > -- Regards Qiao Nuohan