From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH] ASoC: atmel-pcm-dma: Remove
 SND_DMAENGINE_PCM_FLAG_NO_RESIDUE flag
Date: Tue, 07 Jan 2014 10:15:51 +0100
Message-ID: <52CBC5C7.9090802@metafoo.de>
References: <1389018629-11513-1-git-send-email-lars@metafoo.de>
 <52CBC359.7010906@atmel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from smtp-out-033.synserver.de (smtp-out-127.synserver.de
 [212.40.185.127])
 by alsa0.perex.cz (Postfix) with ESMTP id B1E3C26167D
 for <alsa-devel@alsa-project.org>; Tue,  7 Jan 2014 10:15:31 +0100 (CET)
In-Reply-To: <52CBC359.7010906@atmel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Bo Shen <voice.shen@atmel.com>
Cc: Elen Song <elen.song@atmel.com>, Mark Brown <broonie@kernel.org>, Nicolas Ferre <nicolas.ferre@atmel.com>, Liam Girdwood <lgirdwood@gmail.com>, alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

On 01/07/2014 10:05 AM, Bo Shen wrote:
> Hi Lars,
> 
> On 01/06/2014 10:30 PM, Lars-Peter Clausen wrote:
>> Since commit d48de6f1a ("DMA: AT91: Get residual bytes in dma buffer") the
>> at91-dma driver has support for residue reporting. So there is no need to
>> specify the SND_DMAENGINE_PCM_FLAG_NO_RESIDUE flag. This allows for a finer
>> grained resolution of the PCM pointer as well as avoids the race condition
>> that
>> can occur with the period counting that is used when the dmaengine driver
>> does
>> not support residue reporting.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>>
>> ---
>> I don't have the hardware, so only compile tested. It should work though
>> if the
>> residue calculation in the dma driver is implemented correctly.
>> ---
>>   sound/soc/atmel/atmel-pcm-dma.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Thanks for your patch.
> 
> For the dma get residue code, we are improving it. So, I think we'd better
> waiting the improvement done and after let this patch go into mainline.
> 
> What do you think?

If the residue reporting in the dmaengine driver doesn't work properly yet
we have to wait.

- Lars