From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751662AbaAGO07 (ORCPT ); Tue, 7 Jan 2014 09:26:59 -0500 Received: from mail.windriver.com ([147.11.1.11]:52155 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbaAGO0t (ORCPT ); Tue, 7 Jan 2014 09:26:49 -0500 Message-ID: <52CC0EAB.4040501@windriver.com> Date: Tue, 7 Jan 2014 09:26:51 -0500 From: Paul Gortmaker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: "H. Peter Anvin" , CC: Subject: Re: [PATCH] x86: delete non-required instances of include References: <1389054026-12947-1-git-send-email-paul.gortmaker@windriver.com> <52CB8F16.8000009@zytor.com> In-Reply-To: <52CB8F16.8000009@zytor.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.146.65] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-01-07 12:22 AM, H. Peter Anvin wrote: > On 01/06/2014 04:20 PM, Paul Gortmaker wrote: >> None of these files are actually using any __init type directives >> and hence don't need to include . Most are just a >> left over from __devinit and __cpuinit removal, or simply due to >> code getting copied from one driver to the next. >> >> Signed-off-by: Paul Gortmaker >> --- >> >> [build tested allyes/modconfig on x86/build from today's tip tree] >> > > Did you remember to test both 32 and 64 bits? I'm assuming not, since > head_32.S no longer builds: Ah crap, knew I was forgetting something. Will retest and resend; sorry for the wasted cycles. P. -- > > /home/hpa/kernel/tip.x86-cleanups/arch/x86/kernel/head_32.S: Assembler > messages: > /home/hpa/kernel/tip.x86-cleanups/arch/x86/kernel/head_32.S:86: Error: > no such instruction: `__head' > /home/hpa/kernel/tip.x86-cleanups/arch/x86/kernel/head_32.S:476: Error: > no such instruction: `__init' > /home/hpa/kernel/tip.x86-cleanups/arch/x86/kernel/head_32.S:635: Error: > no such instruction: `__initdata' > /home/hpa/kernel/tip.x86-cleanups/arch/x86/kernel/head_32.S:640: Error: > no such instruction: `__refdata' > /home/hpa/kernel/tip.x86-cleanups/arch/x86/kernel/head_32.S:698: Error: > no such instruction: `__initrodata' > make[4]: *** [arch/x86/kernel/head_32.o] Error 1 > > -hpa >