From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Christian_K=F6nig?= Subject: Re: [PATCH] drm/radeon: warn users when hw_i2c is enabled Date: Tue, 07 Jan 2014 16:16:00 +0100 Message-ID: <52CC1A30.9020609@vodafone.de> References: <1389107665-2952-1-git-send-email-alexander.deucher@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id 91BB7FADC2 for ; Tue, 7 Jan 2014 07:16:14 -0800 (PST) In-Reply-To: <1389107665-2952-1-git-send-email-alexander.deucher@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Alex Deucher , dri-devel@lists.freedesktop.org Cc: Alex Deucher , stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Am 07.01.2014 16:14, schrieb Alex Deucher: > The hw i2c engines are disabled by default as the > current implementation is still experimental. Print > a warning when users enable it so that it's obvious > when the option is enabled. > > Signed-off-by: Alex Deucher > Cc: stable@vger.kernel.org Reviewed-by: Christian K=F6nig > --- > drivers/gpu/drm/radeon/radeon_i2c.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon= /radeon_i2c.c > index fc60b74..74bfbf8 100644 > --- a/drivers/gpu/drm/radeon/radeon_i2c.c > +++ b/drivers/gpu/drm/radeon/radeon_i2c.c > @@ -1020,6 +1020,9 @@ void radeon_i2c_destroy(struct radeon_i2c_chan *i2c) > /* Add the default buses */ > void radeon_i2c_init(struct radeon_device *rdev) > { > + if (radeon_hw_i2c =3D=3D 1) > + DRM_INFO("hw_i2c forced on, you may experience display detection probl= ems!\n"); > + > if (rdev->is_atom_bios) > radeon_atombios_i2c_init(rdev); > else