All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [patch] arm64: set correct length of device path end entry
Date: Tue, 07 Jan 2014 18:07:05 +0100	[thread overview]
Message-ID: <52CC3439.1060109@gmail.com> (raw)
In-Reply-To: <20140107170607.GB30907@bivouac.eciton.net>

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

Go ahead.
On 07.01.2014 18:06, Leif Lindholm wrote:
> The length of the Device Path End entry in the grub_linux_boot()
> funtcion is incorrectly set to 0. This triggers an assert failure
> in debug builds of Tianocore.
> 
> The correct length is 4 bytes (1 byte type, 1 byte subtype,
> 2 bytes length).
> 
> Reported-by: Mark Salter <msalter@redhat.com>
> 
> diff --git a/grub-core/loader/arm64/linux.c b/grub-core/loader/arm64/linux.c
> index 9d15aad..7c9bc2b 100644
> --- a/grub-core/loader/arm64/linux.c
> +++ b/grub-core/loader/arm64/linux.c
> @@ -268,7 +268,7 @@ grub_linux_boot (void)
>  
>    mempath[1].header.type = GRUB_EFI_END_DEVICE_PATH_TYPE;
>    mempath[1].header.subtype = GRUB_EFI_END_ENTIRE_DEVICE_PATH_SUBTYPE;
> -  mempath[1].header.length = 0;
> +  mempath[1].header.length = 4;
>  
>    b = grub_efi_system_table->boot_services;
>    status = b->load_image (0, grub_efi_image_handle,
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 274 bytes --]

  reply	other threads:[~2014-01-07 17:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07 17:06 [patch] arm64: set correct length of device path end entry Leif Lindholm
2014-01-07 17:07 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2014-01-07 17:11 ` Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CC3439.1060109@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.