From: Jens Lehmann <Jens.Lehmann@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: George Papanikolaou <g3orge.app@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] mv: better document side effects when moving a submodule
Date: Tue, 07 Jan 2014 18:57:53 +0100 [thread overview]
Message-ID: <52CC4021.60209@web.de> (raw)
In-Reply-To: <xmqq8uushgz3.fsf@gitster.dls.corp.google.com>
Am 06.01.2014 23:40, schrieb Junio C Hamano:
> Jens Lehmann <Jens.Lehmann@web.de> writes:
>> Does this new paragraph make it clearer?
>
> Don't we have bugs section that we can use to list the known
> limitations like this?
Right, will change accordingly in v2.
>> Documentation/git-mv.txt | 10 ++++++++++
>> t/t7001-mv.sh | 21 +++++++++++++++++++++
>
> It also may make sense to express the test as "this is what we would
> like to see happen eventually" in the form of test_expect_failure;
> it is not a big deal though.
We'll get the "what we would like to see happen eventually" test for
free from the recursive submodule update framework I'm currently
implementing, so I propose we don't implement this exepected failure
in this patch.
next prev parent reply other threads:[~2014-01-07 17:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 10:59 mv/rm submodules George Papanikolaou
2013-12-09 17:49 ` Jens Lehmann
2014-01-06 19:21 ` [PATCH] mv: better document side effects when moving a submodule Jens Lehmann
2014-01-06 22:40 ` Junio C Hamano
2014-01-07 17:57 ` Jens Lehmann [this message]
2014-01-07 21:30 ` [PATCH v2 0/2] better document side effects when [re]moving " Jens Lehmann
2014-01-07 21:31 ` [PATCH v2 1/2] mv: better document side effects when moving " Jens Lehmann
2014-01-07 21:32 ` [PATCH v2 2/2] rm: better document side effects when removing " Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CC4021.60209@web.de \
--to=jens.lehmann@web.de \
--cc=g3orge.app@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.