All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Mark Salter <msalter@redhat.com>, linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, patches@linaro.org,
	linux-mm@kvack.org, x86@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Russell King <linux@arm.linux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH v2 1/5] mm: create generic early_ioremap() support
Date: Tue, 07 Jan 2014 15:11:48 -0800	[thread overview]
Message-ID: <52CC89B4.4060300@zytor.com> (raw)
In-Reply-To: <1389062120-31896-2-git-send-email-msalter@redhat.com>

On 01/06/2014 06:35 PM, Mark Salter wrote:
> 
> There is one difference from the existing x86 implementation which
> should be noted. The generic early_memremap() function does not return
> an __iomem pointer and a new early_memunmap() function has been added
> to act as a wrapper for early_iounmap() but with a non __iomem pointer
> passed in. This is in line with the first patch of this series:
> 

This makes a lot of sense.  However, I would suggest that we preface the
patch series with a single patch changing the signature for the existing
x86 function, that way this change becomes bisectable.

	-hpa


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Mark Salter <msalter@redhat.com>, linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, patches@linaro.org,
	linux-mm@kvack.org, x86@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Russell King <linux@arm.linux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH v2 1/5] mm: create generic early_ioremap() support
Date: Tue, 07 Jan 2014 15:11:48 -0800	[thread overview]
Message-ID: <52CC89B4.4060300@zytor.com> (raw)
Message-ID: <20140107231148.WkRKmxL0buDwu6k36PK6RSo_N_qcHrkSIATqALHIYnk@z> (raw)
In-Reply-To: <1389062120-31896-2-git-send-email-msalter@redhat.com>

On 01/06/2014 06:35 PM, Mark Salter wrote:
> 
> There is one difference from the existing x86 implementation which
> should be noted. The generic early_memremap() function does not return
> an __iomem pointer and a new early_memunmap() function has been added
> to act as a wrapper for early_iounmap() but with a non __iomem pointer
> passed in. This is in line with the first patch of this series:
> 

This makes a lot of sense.  However, I would suggest that we preface the
patch series with a single patch changing the signature for the existing
x86 function, that way this change becomes bisectable.

	-hpa



WARNING: multiple messages have this Message-ID (diff)
From: hpa@zytor.com (H. Peter Anvin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] mm: create generic early_ioremap() support
Date: Tue, 07 Jan 2014 15:11:48 -0800	[thread overview]
Message-ID: <52CC89B4.4060300@zytor.com> (raw)
In-Reply-To: <1389062120-31896-2-git-send-email-msalter@redhat.com>

On 01/06/2014 06:35 PM, Mark Salter wrote:
> 
> There is one difference from the existing x86 implementation which
> should be noted. The generic early_memremap() function does not return
> an __iomem pointer and a new early_memunmap() function has been added
> to act as a wrapper for early_iounmap() but with a non __iomem pointer
> passed in. This is in line with the first patch of this series:
> 

This makes a lot of sense.  However, I would suggest that we preface the
patch series with a single patch changing the signature for the existing
x86 function, that way this change becomes bisectable.

	-hpa

  parent reply	other threads:[~2014-01-07 23:11 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07  2:35 [PATCH v2 0/5] generic early_ioremap support Mark Salter
2014-01-07  2:35 ` Mark Salter
2014-01-07  2:35 ` Mark Salter
2014-01-07  2:35 ` [PATCH v2 1/5] mm: create generic early_ioremap() support Mark Salter
2014-01-07  2:35   ` Mark Salter
2014-01-07  2:35   ` Mark Salter
2014-01-07 15:25   ` Catalin Marinas
2014-01-07 15:25     ` Catalin Marinas
2014-01-07 15:25     ` Catalin Marinas
2014-01-07 23:11   ` H. Peter Anvin [this message]
2014-01-07 23:11     ` H. Peter Anvin
2014-01-07 23:11     ` H. Peter Anvin
2014-01-08 16:09     ` Mark Salter
2014-01-08 16:09       ` Mark Salter
2014-01-08 16:09       ` Mark Salter
2014-01-09 10:15       ` Matt Fleming
2014-01-09 10:15         ` Matt Fleming
2014-01-09 10:15         ` Matt Fleming
2014-01-07  2:35 ` [PATCH v2 2/5] x86: use generic early_ioremap Mark Salter
2014-01-07  2:35   ` Mark Salter
2014-01-07  2:35 ` [PATCH v2 3/5] arm: add early_ioremap support Mark Salter
2014-01-07  2:35   ` Mark Salter
2014-01-07  2:35   ` Mark Salter
2014-01-07 17:23   ` Catalin Marinas
2014-01-07 17:23     ` Catalin Marinas
2014-01-07 17:23     ` Catalin Marinas
2014-01-07  2:35 ` [PATCH v2 4/5] arm64: initialize pgprot info earlier in boot Mark Salter
2014-01-07  2:35   ` Mark Salter
2014-01-07  2:35   ` Mark Salter
2014-01-07  2:35 ` [PATCH v2 5/5] arm64: add early_ioremap support Mark Salter
2014-01-07  2:35   ` Mark Salter
2014-01-07  2:35   ` Mark Salter
2014-01-07 17:26 ` [PATCH v2 0/5] generic " Catalin Marinas
2014-01-07 17:26   ` Catalin Marinas
2014-01-07 17:26   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CC89B4.4060300@zytor.com \
    --to=hpa@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mingo@kernel.org \
    --cc=msalter@redhat.com \
    --cc=patches@linaro.org \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.