From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH v2 1/5] mm: create generic early_ioremap() support Date: Tue, 07 Jan 2014 15:11:48 -0800 Message-ID: <52CC89B4.4060300@zytor.com> References: <1389062120-31896-1-git-send-email-msalter@redhat.com> <1389062120-31896-2-git-send-email-msalter@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1389062120-31896-2-git-send-email-msalter@redhat.com> Sender: owner-linux-mm@kvack.org To: Mark Salter , linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, patches@linaro.org, linux-mm@kvack.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, Andrew Morton , Arnd Bergmann , Ingo Molnar , Thomas Gleixner , Russell King , Catalin Marinas , Will Deacon List-Id: linux-arch.vger.kernel.org On 01/06/2014 06:35 PM, Mark Salter wrote: > > There is one difference from the existing x86 implementation which > should be noted. The generic early_memremap() function does not return > an __iomem pointer and a new early_memunmap() function has been added > to act as a wrapper for early_iounmap() but with a non __iomem pointer > passed in. This is in line with the first patch of this series: > This makes a lot of sense. However, I would suggest that we preface the patch series with a single patch changing the signature for the existing x86 function, that way this change becomes bisectable. -hpa -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from terminus.zytor.com ([198.137.202.10]:32822 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753627AbaAGXM4 (ORCPT ); Tue, 7 Jan 2014 18:12:56 -0500 Message-ID: <52CC89B4.4060300@zytor.com> Date: Tue, 07 Jan 2014 15:11:48 -0800 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [PATCH v2 1/5] mm: create generic early_ioremap() support References: <1389062120-31896-1-git-send-email-msalter@redhat.com> <1389062120-31896-2-git-send-email-msalter@redhat.com> In-Reply-To: <1389062120-31896-2-git-send-email-msalter@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Mark Salter , linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, patches@linaro.org, linux-mm@kvack.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, Andrew Morton , Arnd Bergmann , Ingo Molnar , Thomas Gleixner , Russell King , Catalin Marinas , Will Deacon Message-ID: <20140107231148.WkRKmxL0buDwu6k36PK6RSo_N_qcHrkSIATqALHIYnk@z> On 01/06/2014 06:35 PM, Mark Salter wrote: > > There is one difference from the existing x86 implementation which > should be noted. The generic early_memremap() function does not return > an __iomem pointer and a new early_memunmap() function has been added > to act as a wrapper for early_iounmap() but with a non __iomem pointer > passed in. This is in line with the first patch of this series: > This makes a lot of sense. However, I would suggest that we preface the patch series with a single patch changing the signature for the existing x86 function, that way this change becomes bisectable. -hpa From mboxrd@z Thu Jan 1 00:00:00 1970 From: hpa@zytor.com (H. Peter Anvin) Date: Tue, 07 Jan 2014 15:11:48 -0800 Subject: [PATCH v2 1/5] mm: create generic early_ioremap() support In-Reply-To: <1389062120-31896-2-git-send-email-msalter@redhat.com> References: <1389062120-31896-1-git-send-email-msalter@redhat.com> <1389062120-31896-2-git-send-email-msalter@redhat.com> Message-ID: <52CC89B4.4060300@zytor.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/06/2014 06:35 PM, Mark Salter wrote: > > There is one difference from the existing x86 implementation which > should be noted. The generic early_memremap() function does not return > an __iomem pointer and a new early_memunmap() function has been added > to act as a wrapper for early_iounmap() but with a non __iomem pointer > passed in. This is in line with the first patch of this series: > This makes a lot of sense. However, I would suggest that we preface the patch series with a single patch changing the signature for the existing x86 function, that way this change becomes bisectable. -hpa