From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0khN-00011g-I6 for qemu-devel@nongnu.org; Tue, 07 Jan 2014 23:25:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0khG-0005xd-72 for qemu-devel@nongnu.org; Tue, 07 Jan 2014 23:24:57 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57888 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0khG-0005xW-0O for qemu-devel@nongnu.org; Tue, 07 Jan 2014 23:24:50 -0500 Message-ID: <52CCD30C.5030606@suse.de> Date: Wed, 08 Jan 2014 05:24:44 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1387503694-11203-1-git-send-email-agraf@suse.de> <87lhzelc2k.fsf@blackfin.pond.sub.org> <52B6EC8F.8080107@redhat.com> <87k3ebddw0.fsf@blackfin.pond.sub.org> <52CC3275.9010502@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , Igor Mammedov , Markus Armbruster , Peter Maydell Cc: Paolo Bonzini , QEMU Developers , Anthony Liguori , Alexander Graf Am 08.01.2014 04:07, schrieb Peter Crosthwaite: > On Wed, Jan 8, 2014 at 2:59 AM, Paolo Bonzini wro= te: >> Il 07/01/2014 16:12, Markus Armbruster ha scritto: >>> aarch64 akita info qtree crashes >>> aarch64 borzoi info qtree crashes >>> aarch64 spitz info qtree crashes >>> aarch64 terrier info qtree crashes >>> aarch64 tosa info qtree crashes >>> arm akita info qtree crashes >>> arm borzoi info qtree crashes >>> arm spitz info qtree crashes >>> arm terrier info qtree crashes >>> arm tosa info qtree crashes >>> cris axis-dev88 info qtree crashes >> >> The crash is because of commit 7426aa7 (nand: Don't inherit from Sysbu= s, >> 2013-06-18). Should probably be reverted. >> >=20 > Prefer not, under no reasonable definition is NAND a sysbus device. > Whats the real problem here? What is TYPE_SYS_BUS_DEVICE doing WRT to > qtree that TYPE_DEVICE is not? Not fully aware of the context yet, but my response to complaints about info qtree, whether here or from Igor, will be to simply drop it. Anthony has clearly stated on a KVM call that we should not design code to please info qtree but to use the new QOM paradigms. If people don't listen, we must take qdev stuff away for people to realize it - 2.0 is certainly a good point in time. And I had already informally posted a qom-tree Python script to the list that I can turn into a formal patch. My plan was to first extend the qom-test to assure that all machines' properties can be qom-get'ed crash-free, but we can of course skip such safety precautions if that helps avoid weird workarounds. As a reminder, the CPU is not a SysBus device either (ICC on x86, device elsewhere) and I certainly don't want to make it one, especially now that we're about to refactor AddressSpaces. Regards, Andreas P.S. PMM, reading aarch64 above in the context of machines, I don't see a single check-qtest-aarch64-y line in tests/Makefile! Please enable qom-test if qemu-system-aarch64 is already available. Thought you just said it would be linux-user only for 2.0 though? --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg