Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

[Loic Dachary <loic@dachary.org>]

[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]



On 08/01/2014 05:33, Stefan Hajnoczi wrote:
> On Mon, Jan 06, 2014 at 04:50:41PM +0100, Loic Dachary wrote:
>>
>>
>> On 06/01/2014 03:23, Stefan Hajnoczi wrote:
>>> On Mon, Dec 30, 2013 at 01:33:34AM +0100, Loic Dachary wrote:
>>>> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
>>>> index 28ba0d9..af66bbd 100644
>>>> --- a/tests/qemu-iotests/common.rc
>>>> +++ b/tests/qemu-iotests/common.rc
>>>> @@ -189,7 +189,11 @@ _cleanup_test_img()
>>>>              ;;
>>>>  
>>>>          rbd)
>>>> -            rbd rm "$TEST_DIR/t.$IMGFMT" > /dev/null
>>>
>>> stderr will be displayed.  Why isn't this enough?
>>>
>>
>> Because the progress of the removal operation will be displayed on stderr. rbd outputs on stderr even when there is no error.
> 
> Is that a bug in the rbd tool which should be fixed?  Either by printing
> progress to stdout or by adding a --quiet option?

In my opinion, yes. But Josh may disagree ;-)

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]