From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] configs: mx6_common: Restrict CONFIG_ARM_ERRATA_742230 for multi-core
Date: Wed, 08 Jan 2014 09:55:10 +0100 [thread overview]
Message-ID: <52CD126E.4020608@denx.de> (raw)
In-Reply-To: <1389014059-9894-1-git-send-email-fabio.estevam@freescale.com>
Hi Fabio,
On 06/01/2014 14:14, Fabio Estevam wrote:
> According to e9fd66defd (ARM: mx6: define CONFIG_ARM_ERRATA_742230), the
> CONFIG_ARM_ERRATA_742230 option should only be applied to multi-core
> variants, so restrict its usage for quad and dual-lite only.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> include/configs/mx6_common.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h
> index 514d634..0b8db85 100644
> --- a/include/configs/mx6_common.h
> +++ b/include/configs/mx6_common.h
> @@ -17,7 +17,9 @@
> #ifndef __MX6_COMMON_H
> #define __MX6_COMMON_H
>
> +#if defined(CONFIG_MX6Q) || defined(CONFIG_MX6DL)
> #define CONFIG_ARM_ERRATA_742230
> +#endif
> #define CONFIG_ARM_ERRATA_743622
> #define CONFIG_ARM_ERRATA_751472
> #define CONFIG_BOARD_POSTCLK_INIT
>
In Kernel I cannot read that the errata is related to a multicore
processor. Indeed, it is related to the Cortex-A9 version.
"This option enables the workaround for the 742230 Cortex-A9
(r1p0..r2p2) erratum. Under rare circumstances, a DMB instruction
between two write operations may not ensure the correct visibility
ordering of the two writes. This workaround sets a specific bit in
the diagnostic register of the Cortex-A9 which causes the DMB
instruction to behave as a DSB, ensuring the correct behaviour of
the two writes.
"
The fix was merged in kernel since a lot of time, before having
multicore processors for ARM. At least the commit message does not seem
coherent with the explanations in kernel. Maybe has solo a upgraded core
version as dual/quad ?
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2014-01-08 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 13:14 [U-Boot] [PATCH 1/2] configs: mx6_common: Restrict CONFIG_ARM_ERRATA_742230 for multi-core Fabio Estevam
2014-01-06 13:14 ` [U-Boot] [PATCH 2/2] mx6slevk: Include "mx6_common.h" Fabio Estevam
2014-01-08 8:55 ` Stefano Babic [this message]
2014-01-08 12:10 ` [U-Boot] [PATCH 1/2] configs: mx6_common: Restrict CONFIG_ARM_ERRATA_742230 for multi-core Shawn Guo
2014-01-08 13:42 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CD126E.4020608@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.