From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Subject: Re: [PATCH 82/85] drivers: gpu: Mark functions as static in vmwgfx_kms.c Date: Wed, 08 Jan 2014 13:36:07 +0100 Message-ID: <52CD4637.8010805@vmware.com> References: <477dcfde0b9247c91030dedcbf71af7dafdb7bf4.1389018325.git.rashika.kheria@gmail.com> <20140107105154.GC4891@leaf> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp-outbound-2.vmware.com (smtp-outbound-2.vmware.com [208.91.2.13]) by gabe.freedesktop.org (Postfix) with ESMTP id B8682FA7A3 for ; Wed, 8 Jan 2014 04:36:12 -0800 (PST) In-Reply-To: <20140107105154.GC4891@leaf> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Josh Triplett Cc: Daniel Vetter , Linux Kernel Mailing List , DRI Development , Rashika Kheria , Rob Clark , Dave Airlie List-Id: dri-devel@lists.freedesktop.org T24gMDEvMDcvMjAxNCAxMTo1MSBBTSwgSm9zaCBUcmlwbGV0dCB3cm90ZToKPiBPbiBUdWUsIEph biAwNywgMjAxNCBhdCAxMToyMToxMkFNICswMTAwLCBKYWtvYiBCb3JuZWNyYW50eiB3cm90ZToK Pj4gT24gTW9uLCBKYW4gNiwgMjAxNCBhdCA1OjQ4IFBNLCBSYXNoaWthIEtoZXJpYSA8cmFzaGlr YS5raGVyaWFAZ21haWwuY29tPiB3cm90ZToKPj4+IE1hcmsgZnVuY3Rpb25zIGFzIHN0YXRpYyBi ZWNhdXNlIHRoZXkgYXJlIG5vdCB1c2VkIG91dHNpZGUgdGhlIGZpbGUKPj4+IGRybS92bXdnZngv dm13Z2Z4X2ttcy5jLgo+Pj4KPj4+IFRoaXMgZWxpbWluYXRlcyB0aGUgZm9sbG93aW5nIHdhcm5p bmdzIGluIGRybS92bXdnZngvdm13Z2Z4X2ttcy5jOgo+Pj4gZHJpdmVycy9ncHUvZHJtL3Ztd2dm eC92bXdnZnhfa21zLmM6NDM6Njogd2FybmluZzogbm8gcHJldmlvdXMgcHJvdG90eXBlIGZvciDi gJh2bXdfY2xpcF9jbGlwcmVjdHPigJkgWy1XbWlzc2luZy1wcm90b3R5cGVzXQo+Pj4gZHJpdmVy cy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfa21zLmM6NDI2OjY6IHdhcm5pbmc6IG5vIHByZXZpb3Vz IHByb3RvdHlwZSBmb3Ig4oCYdm13X2ZyYW1lYnVmZmVyX3N1cmZhY2VfZGVzdHJveeKAmSBbLVdt aXNzaW5nLXByb3RvdHlwZXNdCj4+PiBkcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9rbXMu Yzo1OTI6NTogd2FybmluZzogbm8gcHJldmlvdXMgcHJvdG90eXBlIGZvciDigJh2bXdfZnJhbWVi dWZmZXJfc3VyZmFjZV9kaXJ0eeKAmSBbLVdtaXNzaW5nLXByb3RvdHlwZXNdCj4+PiBkcml2ZXJz L2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9rbXMuYzo3NTc6Njogd2FybmluZzogbm8gcHJldmlvdXMg cHJvdG90eXBlIGZvciDigJh2bXdfZnJhbWVidWZmZXJfZG1hYnVmX2Rlc3Ryb3nigJkgWy1XbWlz c2luZy1wcm90b3R5cGVzXQo+Pj4gZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfa21zLmM6 OTQzOjU6IHdhcm5pbmc6IG5vIHByZXZpb3VzIHByb3RvdHlwZSBmb3Ig4oCYdm13X2ZyYW1lYnVm ZmVyX2RtYWJ1Zl9kaXJ0eeKAmSBbLVdtaXNzaW5nLXByb3RvdHlwZXNdCj4+PiBkcml2ZXJzL2dw dS9kcm0vdm13Z2Z4L3Ztd2dmeF9rbXMuYzoxNjY2OjU6IHdhcm5pbmc6IG5vIHByZXZpb3VzIHBy b3RvdHlwZSBmb3Ig4oCYdm13X2R1X3VwZGF0ZV9sYXlvdXTigJkgWy1XbWlzc2luZy1wcm90b3R5 cGVzXQo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IFJhc2hpa2EgS2hlcmlhIDxyYXNoaWthLmtoZXJp YUBnbWFpbC5jb20+Cj4+PiBSZXZpZXdlZC1ieTogSm9zaCBUcmlwbGV0dCA8am9zaEBqb3NodHJp cGxldHQub3JnPgo+Pj4gLS0tCj4+PiAgZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfa21z LmMgfCAgIDEyICsrKysrKy0tLS0tLQo+Pj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMo KyksIDYgZGVsZXRpb25zKC0pCj4+Cj4+IFRoaXMgYW5kIHBhdGNoIDgzLCA4NCwgODUgYXJlCj4+ IFJldmlld2VkLWJ5OiBKYWtvYiBCb3JuZWNyYW50eiA8amFrb2JAdm13YXJlLmNvbT4KPiBDYW4g eW91IHRha2UgdGhlbSB0aHJvdWdoIHlvdXIgdHJlZSwgb3IgYXJlIHlvdSBleHBlY3RpbmcgdGhl bSB0byBmb2xsb3cKPiBhbm90aGVyIHBhdGg/CgpJJ2xsIHRha2UgdGhlbSB0aHJvdWdoIHZtd2dm eC1uZXh0LiBIb3dldmVyLCBwYXRjaCA4My84NSBjb25mbGljdHMKaGVhdmlseSB3aXRoIGFuIGlu dGVybmFsIHZtd2dmeCBwYXRjaCBzZXJpZXMuIElmIGFwcGxpY2FibGUsIEknbGwgYXBwbHkKaXQg YWZ0ZXIgcmVzb2x2aW5nIHRob3NlIGNvbmZsaWN0cy4KClRoYW5rcywKCi9UaG9tYXMKCgoKPgo+ IC0gSm9zaCBUcmlwbGV0dAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756558AbaAHMgO (ORCPT ); Wed, 8 Jan 2014 07:36:14 -0500 Received: from smtp-outbound-2.vmware.com ([208.91.2.13]:46163 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755610AbaAHMgM (ORCPT ); Wed, 8 Jan 2014 07:36:12 -0500 Message-ID: <52CD4637.8010805@vmware.com> Date: Wed, 08 Jan 2014 13:36:07 +0100 From: Thomas Hellstrom User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Josh Triplett CC: Jakob Bornecrantz , Daniel Vetter , Linux Kernel Mailing List , DRI Development , Rashika Kheria , Dave Airlie , Rob Clark Subject: Re: [PATCH 82/85] drivers: gpu: Mark functions as static in vmwgfx_kms.c References: <477dcfde0b9247c91030dedcbf71af7dafdb7bf4.1389018325.git.rashika.kheria@gmail.com> <20140107105154.GC4891@leaf> In-Reply-To: <20140107105154.GC4891@leaf> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/07/2014 11:51 AM, Josh Triplett wrote: > On Tue, Jan 07, 2014 at 11:21:12AM +0100, Jakob Bornecrantz wrote: >> On Mon, Jan 6, 2014 at 5:48 PM, Rashika Kheria wrote: >>> Mark functions as static because they are not used outside the file >>> drm/vmwgfx/vmwgfx_kms.c. >>> >>> This eliminates the following warnings in drm/vmwgfx/vmwgfx_kms.c: >>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:43:6: warning: no previous prototype for ‘vmw_clip_cliprects’ [-Wmissing-prototypes] >>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:426:6: warning: no previous prototype for ‘vmw_framebuffer_surface_destroy’ [-Wmissing-prototypes] >>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:592:5: warning: no previous prototype for ‘vmw_framebuffer_surface_dirty’ [-Wmissing-prototypes] >>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:757:6: warning: no previous prototype for ‘vmw_framebuffer_dmabuf_destroy’ [-Wmissing-prototypes] >>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:943:5: warning: no previous prototype for ‘vmw_framebuffer_dmabuf_dirty’ [-Wmissing-prototypes] >>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1666:5: warning: no previous prototype for ‘vmw_du_update_layout’ [-Wmissing-prototypes] >>> >>> Signed-off-by: Rashika Kheria >>> Reviewed-by: Josh Triplett >>> --- >>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 12 ++++++------ >>> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> This and patch 83, 84, 85 are >> Reviewed-by: Jakob Bornecrantz > Can you take them through your tree, or are you expecting them to follow > another path? I'll take them through vmwgfx-next. However, patch 83/85 conflicts heavily with an internal vmwgfx patch series. If applicable, I'll apply it after resolving those conflicts. Thanks, /Thomas > > - Josh Triplett > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel