All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Keir Fraser <keir@xen.org>, Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [Patch] common/kexec: Identify which cpu the kexec image is being executed on.
Date: Wed, 8 Jan 2014 13:20:05 +0000	[thread overview]
Message-ID: <52CD5085.1050903@citrix.com> (raw)
In-Reply-To: <52CC1D5702000078001112C5@nat28.tlf.novell.com>

On 07/01/14 14:29, Jan Beulich wrote:
>>>> On 06.01.14 at 12:59, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> --- a/xen/common/kexec.c
>> +++ b/xen/common/kexec.c
>> @@ -265,6 +265,8 @@ static int noinline one_cpu_only(void)
>>      }
>>  
>>      set_bit(KEXEC_FLAG_IN_PROGRESS, &kexec_flags);
>> +    printk("Executing crash image on cpu%u\n", cpu);
>> +
>>      return 0;
>>  }
>>  
> 
> With the calling function also being used from kexec_reboot(),
> printing "crash image" here isn't really correct afaict.

Good point.

David

      reply	other threads:[~2014-01-08 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06 11:59 [Patch] common/kexec: Identify which cpu the kexec image is being executed on Andrew Cooper
2014-01-06 17:39 ` David Vrabel
2014-01-07 14:29 ` Jan Beulich
2014-01-08 13:20   ` David Vrabel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CD5085.1050903@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.