From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Behme Date: Wed, 8 Jan 2014 15:07:22 +0100 Subject: [U-Boot] [PATCH v2 1/2] configs: mx6_common: Restrict CONFIG_ARM_ERRATA_742230 for multi-core In-Reply-To: <1389189577-3092-1-git-send-email-festevam@gmail.com> References: <1389189577-3092-1-git-send-email-festevam@gmail.com> Message-ID: <52CD5B9A.3060708@de.bosch.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Fabio, On 08.01.2014 14:59, Fabio Estevam wrote: > From: Fabio Estevam > > According to e9fd66defd (ARM: mx6: define CONFIG_ARM_ERRATA_742230), the > CONFIG_ARM_ERRATA_742230 option should only be applied to multi-core > variants, so restrict its usage for quad and dual-lite only. Just for my understanding: Is there a technical reason not to use this errata on single core (solo/sololite)? I.e. do you see any real issues using this errata on solo/sololite? Or is this patch "just out of formal" aspects? I.e. there are no positive/negative issues seen on solo/sololite, but the documentation tells that it shouldn't be used on solo/sololite, so disable it? Best regards Dirk > Quoting Shawn Guo [2]: > > "The sololite has the same core version as dual/quad - r2p10. The > help text of erratum 742230 in kernel suggests that only version > r1p0..r2p2 are affected. So it sounds like the erratum 742230 should be > irrelevant to i.MX6 SoCs. However we were running into a reboot issue > on multi-core i.MX6 SoCs. There was a quite long discussion [1] about > it. Though we did not reach a conclusion in the thread, one ARM people > sent me a private message, suggesting this should be an ARM core issue > and workaround for erratum 742230 might help. And it turns out what he > said is true. And that's why I came up with the commit e9fd66defd (ARM: > mx6: define CONFIG_ARM_ERRATA_742230) to turn on the erratum for imx6 > dual/quad. > > Shawn > > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2012-August/thread.html#113096" > > [2] http://lists.denx.de/pipermail/u-boot/2014-January/170424.html > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Improve commit log > > include/configs/mx6_common.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h > index 514d634..0b8db85 100644 > --- a/include/configs/mx6_common.h > +++ b/include/configs/mx6_common.h > @@ -17,7 +17,9 @@ > #ifndef __MX6_COMMON_H > #define __MX6_COMMON_H > > +#if defined(CONFIG_MX6Q) || defined(CONFIG_MX6DL) > #define CONFIG_ARM_ERRATA_742230 > +#endif > #define CONFIG_ARM_ERRATA_743622 > #define CONFIG_ARM_ERRATA_751472 > #define CONFIG_BOARD_POSTCLK_INIT