From: Paolo Bonzini <pbonzini@redhat.com>
To: Yan Vugenfirer <yvugenfi@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel list <qemu-devel@nongnu.org>,
Ronen Hod <rhod@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
Dmitry Fleytman <dfleytma@redhat.com>,
Miki Mishael <mmishael@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf
Date: Wed, 08 Jan 2014 17:11:48 +0100 [thread overview]
Message-ID: <52CD78C4.8070403@redhat.com> (raw)
In-Reply-To: <DECD048F-03FE-42EB-9358-75B1D1849669@redhat.com>
Il 08/01/2014 16:07, Yan Vugenfirer ha scritto:
>>>
>>> +%QEMU-PCI_SERIAL_1_PORT%=ComPort_inst1,
>>> PCI\VEN_1B36&DEV_0002&SUBSYS_11001AF4&REV_01
>>> +%QEMU-PCI_SERIAL_2_PORT%=ComPort_inst2,
>>> PCI\VEN_1B36&DEV_0003&SUBSYS_11001AF4&REV_01
>>> +%QEMU-PCI_SERIAL_4_PORT%=ComPort_inst4,
>>> PCI\VEN_1B36&DEV_0004&SUBSYS_11001AF4&REV_01
>>
>> I think checking the subsystem is not necessary (and I think downstreams
>> could legitimately change it). Can you check CC and REV but not SUBSYS?
>
> PNP ID can be reduced to vendor and device ID only, for example:
> PCI\VEN_1B36&DEV_0002 . But in this case we cannot check revision.
Gerd, Michael, what do you think is better? Not check revision, or
enforcing subsystem?
Paolo
next prev parent reply other threads:[~2014-01-08 16:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 15:04 [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf Miki Mishael
2014-01-07 14:45 ` Paolo Bonzini
2014-01-08 15:07 ` Yan Vugenfirer
2014-01-08 16:11 ` Paolo Bonzini [this message]
2014-01-08 16:38 ` Michael S. Tsirkin
2014-01-13 10:13 ` Gerd Hoffmann
2014-01-13 14:48 ` Michael S. Tsirkin
2014-01-13 14:56 ` Paolo Bonzini
2014-01-13 15:03 ` Michael S. Tsirkin
2014-01-13 15:04 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2014-01-16 12:18 [Qemu-devel] [PATCH V2 00/01] " Miki Mishael
2014-01-16 12:18 ` [Qemu-devel] [PATCH] " Miki Mishael
2014-01-16 14:44 ` Gerd Hoffmann
2014-01-16 21:12 ` Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CD78C4.8070403@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@amazon.com \
--cc=dfleytma@redhat.com \
--cc=kraxel@redhat.com \
--cc=mmishael@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rhod@redhat.com \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.