All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: stefanha@redhat.com, sw@weilnetz.de, mjt@tls.msk.ru,
	qemu-devel@nongnu.org, lcapitulino@redhat.com,
	blauwirbel@gmail.com, aliguori@amazon.com, afaerber@suse.de,
	rth@twiddle.net
Subject: Re: [Qemu-devel] [RFC 0/5] -object/object-add support custom location and 2nd stage initialization
Date: Wed, 08 Jan 2014 18:33:11 +0100	[thread overview]
Message-ID: <52CD8BD7.8070706@redhat.com> (raw)
In-Reply-To: <20140108175159.029e5f9e@nial.usersys.redhat.com>

Il 08/01/2014 17:51, Igor Mammedov ha scritto:
>> > 
>> > Thanks Igor!  I like very much patches 1-4 (though I'm thinking that we
>> > need some style conventions for interfaces).  I think patch 5 adds more
>> > complexity than we need, but I'm open to discussion.
> I'm sorry that it took so long.
> The reason for separate interfaces is that realize interface is more generic
> and might be used outside of '-object'. While I don't see 'path' interface
> ever used outside of -object.

Yeah, I think the two interfaces are a good idea.  The question is
whether we want the second interface at all.  I think it's fine to
delegate namespace conventions to management.

Regarding the "overloading" of the realize name, I was against it in
previous discussion and I still am (I was in favor of something like
UserCreatable and naming the method "complete" or "construct"), but I
didn't want to sound too negative. :)

Paolo

  reply	other threads:[~2014-01-08 17:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08 16:09 [Qemu-devel] [RFC 0/5] -object/object-add support custom location and 2nd stage initialization Igor Mammedov
2014-01-08 16:09 ` [Qemu-devel] [PATCH 1/5] object_add: consolidate error handling Igor Mammedov
2014-01-08 16:09 ` [Qemu-devel] [PATCH 2/5] add optional 2nd stage initialization to -object/object-add/object_add commands Igor Mammedov
2014-01-08 16:09 ` [Qemu-devel] [PATCH 3/5] virtio_rng: use object_realize interface instead of calling backend API Igor Mammedov
2014-01-08 16:09 ` [Qemu-devel] [PATCH 4/5] vl.c: -object: handle duplicate 'id' properly Igor Mammedov
2014-01-08 16:09 ` [Qemu-devel] [PATCH 5/5] -object/object-add: use custom default object location if provided Igor Mammedov
2014-01-09  4:35   ` Stefan Hajnoczi
2014-01-10 10:59     ` Igor Mammedov
2014-01-08 16:24 ` [Qemu-devel] [RFC 0/5] -object/object-add support custom location and 2nd stage initialization Paolo Bonzini
2014-01-08 16:45   ` Andreas Färber
2014-01-08 17:00     ` Igor Mammedov
2014-01-08 16:51   ` Igor Mammedov
2014-01-08 17:33     ` Paolo Bonzini [this message]
2014-01-10 11:28       ` Igor Mammedov
2014-01-10 11:38         ` Paolo Bonzini
2014-01-10 14:44           ` Igor Mammedov
2014-01-10 15:40             ` Paolo Bonzini
2014-01-10 15:31         ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CD8BD7.8070706@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@amazon.com \
    --cc=blauwirbel@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.