From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0xwA-0006L4-IF for qemu-devel@nongnu.org; Wed, 08 Jan 2014 13:33:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0xw4-0003Xg-L0 for qemu-devel@nongnu.org; Wed, 08 Jan 2014 13:33:06 -0500 Sender: Richard Henderson Message-ID: <52CD99D8.5070503@twiddle.net> Date: Wed, 08 Jan 2014 10:32:56 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1389110770-5199-1-git-send-email-tommusta@gmail.com> <1389110770-5199-18-git-send-email-tommusta@gmail.com> In-Reply-To: <1389110770-5199-18-git-send-email-tommusta@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [V4 PATCH 17/22] target-ppc: Fix and enable fri[mnpz] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org On 01/07/2014 08:06 AM, Tom Musta wrote: > The fri* series of instructions was introduced prior to ISA 2.06 and > is supported on Power7 and Power8 hardware. However, the instruction > is still considered illegal in the P7 and P8 QEMU emulation models. > This patch enables these instructions for the P7 and P8 machines. > > Also, the existing helper is modified to correctly handle some of > the boundary cases (NaNs and the inexact flag). > > Signed-off-by: Tom Musta > --- > V4: frin changed to use "ties away" rounding mode per Richard Henderson's > review. Modified NaN handling. Proper handling of stickiness of > the inexact flag. Added to P7+ model. > > target-ppc/fpu_helper.c | 18 +++++++++++------- > target-ppc/translate_init.c | 3 +++ > 2 files changed, 14 insertions(+), 7 deletions(-) Reviewed-by: Richard Henderson r~