From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v2 3/6] ARM: tegra: Add efuse bindings Date: Wed, 08 Jan 2014 15:41:52 -0700 Message-ID: <52CDD430.3010508@wwwdotorg.org> References: <1387891931-9854-1-git-send-email-pdeschrijver@nvidia.com> <1387891931-9854-4-git-send-email-pdeschrijver@nvidia.com> <52CB14D3.2060904@wwwdotorg.org> <20140108133951.GD1592@ulmo.nvidia.com> <52CD9DFB.9010007@wwwdotorg.org> <20140108200946.GE1298@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: In-Reply-To: <20140108200946.GE1298-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: Peter De Schrijver , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 01/08/2014 01:09 PM, Thierry Reding wrote: > On Wed, Jan 08, 2014 at 11:50:35AM -0700, Stephen Warren wrote: >> On 01/08/2014 06:39 AM, Thierry Reding wrote: >>> On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote: >>>> On 12/24/2013 06:32 AM, Peter De Schrijver wrote: >>> [...] >>>>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi >>>> >>>>> + efuse@7000F800 { >>>> >>>> "fuse" might be a better node name; "efuse" is presumably the name of >>>> the instance, not the type of object. >>> >>> There's another occurrence I noticed recently where we haven't followed >>> that rule. The PMIC node on Venice2 for instance is called as3722. >>> Perhaps that should also be renamed. >> >> Yes, we should fix that. Care to send a patch? > > Ugh... I've just been going through some of the other DTS files and see > that quite a lot of other places aren't following this rule either. The ... > Perhaps it isn't worth fixing them all up after all? I guess that just means the patch will be a little bigger; it doesn't seem like that's a good reason not to fix the issue. From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Wed, 08 Jan 2014 15:41:52 -0700 Subject: [PATCH v2 3/6] ARM: tegra: Add efuse bindings In-Reply-To: <20140108200946.GE1298@ulmo.nvidia.com> References: <1387891931-9854-1-git-send-email-pdeschrijver@nvidia.com> <1387891931-9854-4-git-send-email-pdeschrijver@nvidia.com> <52CB14D3.2060904@wwwdotorg.org> <20140108133951.GD1592@ulmo.nvidia.com> <52CD9DFB.9010007@wwwdotorg.org> <20140108200946.GE1298@ulmo.nvidia.com> Message-ID: <52CDD430.3010508@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/08/2014 01:09 PM, Thierry Reding wrote: > On Wed, Jan 08, 2014 at 11:50:35AM -0700, Stephen Warren wrote: >> On 01/08/2014 06:39 AM, Thierry Reding wrote: >>> On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote: >>>> On 12/24/2013 06:32 AM, Peter De Schrijver wrote: >>> [...] >>>>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi >>>> >>>>> + efuse at 7000F800 { >>>> >>>> "fuse" might be a better node name; "efuse" is presumably the name of >>>> the instance, not the type of object. >>> >>> There's another occurrence I noticed recently where we haven't followed >>> that rule. The PMIC node on Venice2 for instance is called as3722. >>> Perhaps that should also be renamed. >> >> Yes, we should fix that. Care to send a patch? > > Ugh... I've just been going through some of the other DTS files and see > that quite a lot of other places aren't following this rule either. The ... > Perhaps it isn't worth fixing them all up after all? I guess that just means the patch will be a little bigger; it doesn't seem like that's a good reason not to fix the issue. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757637AbaAHWmA (ORCPT ); Wed, 8 Jan 2014 17:42:00 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:58277 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757357AbaAHWl5 (ORCPT ); Wed, 8 Jan 2014 17:41:57 -0500 Message-ID: <52CDD430.3010508@wwwdotorg.org> Date: Wed, 08 Jan 2014 15:41:52 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Thierry Reding CC: Peter De Schrijver , linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , devicetree@vger.kernel.org Subject: Re: [PATCH v2 3/6] ARM: tegra: Add efuse bindings References: <1387891931-9854-1-git-send-email-pdeschrijver@nvidia.com> <1387891931-9854-4-git-send-email-pdeschrijver@nvidia.com> <52CB14D3.2060904@wwwdotorg.org> <20140108133951.GD1592@ulmo.nvidia.com> <52CD9DFB.9010007@wwwdotorg.org> <20140108200946.GE1298@ulmo.nvidia.com> In-Reply-To: <20140108200946.GE1298@ulmo.nvidia.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/08/2014 01:09 PM, Thierry Reding wrote: > On Wed, Jan 08, 2014 at 11:50:35AM -0700, Stephen Warren wrote: >> On 01/08/2014 06:39 AM, Thierry Reding wrote: >>> On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote: >>>> On 12/24/2013 06:32 AM, Peter De Schrijver wrote: >>> [...] >>>>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi >>>> >>>>> + efuse@7000F800 { >>>> >>>> "fuse" might be a better node name; "efuse" is presumably the name of >>>> the instance, not the type of object. >>> >>> There's another occurrence I noticed recently where we haven't followed >>> that rule. The PMIC node on Venice2 for instance is called as3722. >>> Perhaps that should also be renamed. >> >> Yes, we should fix that. Care to send a patch? > > Ugh... I've just been going through some of the other DTS files and see > that quite a lot of other places aren't following this rule either. The ... > Perhaps it isn't worth fixing them all up after all? I guess that just means the patch will be a little bigger; it doesn't seem like that's a good reason not to fix the issue.