From: Or Gerlitz <ogerlitz@mellanox.com>
To: Jerry Chu <hkchu@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Yan Burman <yanb@mellanox.com>,
Shlomo Pongratz <shlomop@mellanox.com>
Subject: Re: [PATCH net-next V2 1/3] net: Add GRO support for UDP encapsulating protocols
Date: Thu, 9 Jan 2014 09:19:22 +0200 [thread overview]
Message-ID: <52CE4D7A.1070804@mellanox.com> (raw)
In-Reply-To: <CAPshTChSSB8mycXMXSJ656tpBGDqyjUF37+V2S2eAPQs47gJ2A@mail.gmail.com>
On 09/01/2014 05:12, Jerry Chu wrote:
>> >
>> >
>>> >>Also "udp_offload" is a little misleading - you are not trying to GRO UDP
>>> >>pkts where UDP is the real transport. You are only trying to GRO UDP
>>> >>encapped TCP pkts.
>> >
>> >
>> >Indeed -- however, I just plugged into what was there for GSO, e.g stack
>> >will not do GSO for plain UDP
>> >packets, only for those who encapsulate something the code that does this is
>> >udp_offloads.c -- any suggestion
>> >how to phrase/frame the change you envision?
> There is already udpv4_offload for real udp gso (ufo) offload. How about "udp_encap_offload" for your stuff?
>
well, I don't see how it can work... the problem with your suggestion is
that we'll have two structures to compete on the UDP protocol entry in
the inet offloads structure, one that holds the current udp gso offloads
and one with the udp gro offloads.
next prev parent reply other threads:[~2014-01-09 7:19 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 15:29 [PATCH net-next V2 0/3] net: Add GRO support for UDP encapsulating protocols Or Gerlitz
2014-01-07 15:29 ` [PATCH net-next V2 1/3] " Or Gerlitz
2014-01-07 16:33 ` Eric Dumazet
2014-01-07 20:19 ` Or Gerlitz
2014-01-07 20:32 ` Eric Dumazet
2014-01-07 20:37 ` Or Gerlitz
2014-01-07 21:38 ` Eric Dumazet
2014-01-08 8:04 ` Or Gerlitz
[not found] ` <1389182291.26646.79.camel@edumazet-glaptop2.roam.corp.google.com>
2014-01-08 12:15 ` Or Gerlitz
2014-01-07 22:11 ` Jerry Chu
2014-01-08 8:02 ` Or Gerlitz
2014-01-09 3:12 ` Jerry Chu
2014-01-09 6:35 ` Or Gerlitz
2014-01-09 7:19 ` Or Gerlitz [this message]
2014-01-07 18:44 ` Tom Herbert
2014-01-07 20:21 ` Or Gerlitz
2014-01-07 23:04 ` Tom Herbert
2014-01-08 16:11 ` Or Gerlitz
2014-01-08 16:29 ` Tom Herbert
2014-01-08 16:31 ` Or Gerlitz
2014-01-07 21:19 ` David Miller
2014-01-07 21:40 ` Tom Herbert
2014-01-07 15:29 ` [PATCH net-next V2 2/3] net: Export gro_find_by_type helpers Or Gerlitz
2014-01-07 15:29 ` [PATCH net-next V2 3/3] net: Add GRO support for vxlan traffic Or Gerlitz
2014-01-07 16:34 ` Eric Dumazet
2014-01-07 19:43 ` Or Gerlitz
2014-01-07 20:04 ` Eric Dumazet
2014-01-07 20:10 ` Or Gerlitz
2014-01-07 18:08 ` Tom Herbert
2014-01-07 19:43 ` Or Gerlitz
2014-01-07 20:02 ` Eric Dumazet
2014-01-07 20:12 ` Or Gerlitz
2014-01-07 21:09 ` Tom Herbert
2014-01-08 9:45 ` Or Gerlitz
[not found] ` <CAJZOPZLsMvmHwmMjhsuKb__2HncMXMm=p6UFnT4XX5d8hZnGxw@mail.gmail.com>
2014-01-07 19:52 ` Tom Herbert
2014-01-07 16:45 ` [PATCH net-next V2 0/3] net: Add GRO support for UDP encapsulating protocols Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CE4D7A.1070804@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=hkchu@google.com \
--cc=netdev@vger.kernel.org \
--cc=shlomop@mellanox.com \
--cc=yanb@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.