All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] configs: mx6_common: Restrict CONFIG_ARM_ERRATA_742230 for multi-core
Date: Thu, 09 Jan 2014 12:10:52 +0100	[thread overview]
Message-ID: <52CE83BC.2000008@denx.de> (raw)
In-Reply-To: <20140109062823.GC21717@S2101-09.ap.freescale.net>

Hi Shawn,

On 09/01/2014 07:28, Shawn Guo wrote:
> On Thu, Jan 09, 2014 at 03:50:06AM +0000, Hui.Liu at freescale.com wrote:
>> The commit log really get me confused, why we need enable one ERRATA which should not be applied?
> 
> It's been enabled as a workaround for the reboot issue we were seeing
> before.  But I get reminded that the workaround may not be needed
> anymore, because of the recent kernel commit 87a84b69 (ARM: imx: replace
> imx6q_restart() with mxc_restart()).  The real change is that we do not
> call of_iomap() in restart hook now.
> 
> Fabio,
> 
> Can you give it a test to see if reboot works fine with v3.13-rc kernel
> with dropping the ERRATA from u-boot?  If reboot works and nothing else
> breaks, we may want to just remove the ERRATA selection from u-boot.
> 

+1

If the workaround must be set for dual/quad, it is not clear to me if
there are some disadvantages to let it enabled for solo.


>> This will make customer confused at all. We need find the real root-cause for it other than hack it
>> Otherwise, you will get more and more problems sooner or later...
> 
> If you go through the thread [1], you will see that the root-cause had
> pretty much been identified, - issuing dmb instructions in a tight loop
> causes the problem.  But people did not reach a conclusion how it should
> be fixed.

Exactly, and more frightening IMHO is what can happen is user space if
gcc uses dmb.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      parent reply	other threads:[~2014-01-09 11:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08 13:59 [U-Boot] [PATCH v2 1/2] configs: mx6_common: Restrict CONFIG_ARM_ERRATA_742230 for multi-core Fabio Estevam
2014-01-08 13:59 ` [U-Boot] [PATCH v2 2/2] mx6slevk: Include "mx6_common.h" Fabio Estevam
2014-01-08 14:07 ` [U-Boot] [PATCH v2 1/2] configs: mx6_common: Restrict CONFIG_ARM_ERRATA_742230 for multi-core Dirk Behme
2014-01-08 14:14   ` Fabio Estevam
2014-01-09  3:50 ` Hui.Liu at freescale.com
2014-01-09  6:28   ` Shawn Guo
2014-01-09 10:55     ` Fabio Estevam
2014-01-09 11:12       ` Stefano Babic
2014-01-09 11:10     ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CE83BC.2000008@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.