From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1EKR-0005NB-Un for qemu-devel@nongnu.org; Thu, 09 Jan 2014 07:03:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1EKM-0003KJ-Ui for qemu-devel@nongnu.org; Thu, 09 Jan 2014 07:03:15 -0500 Received: from cantor2.suse.de ([195.135.220.15]:34361 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1EKM-0003KD-OZ for qemu-devel@nongnu.org; Thu, 09 Jan 2014 07:03:10 -0500 Message-ID: <52CE8FFA.5060800@suse.de> Date: Thu, 09 Jan 2014 13:03:06 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1389258650-22834-1-git-send-email-will.newton@linaro.org> In-Reply-To: <1389258650-22834-1-git-send-email-will.newton@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] linux-user: Remove regs parameter load_elf_binary and load_flt_binary List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Will Newton , qemu-devel@nongnu.org Cc: Riku Voipio "... of load_elf_binary() and load_flt_binary()" - Riku can you fix pls? Am 09.01.2014 10:10, schrieb Will Newton: > The regs parameter is not used anywhere, so remove it. >=20 > Signed-off-by: Will Newton > --- > linux-user/elfload.c | 3 +-- > linux-user/flatload.c | 3 +-- > linux-user/linuxload.c | 4 ++-- > linux-user/qemu.h | 6 ++---- > 4 files changed, 6 insertions(+), 10 deletions(-) Please CC your colleague as the maintainer, scripts/get_maintainer.pl --nogit-fallback can help automate that. Also you probably wanted patches@linaro.org, too. ;) That said, patch contents look fine, without knowing the history, Reviewed-by: Andreas F=E4rber Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg