From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] What's the need of OCFS2_INODE_MAYBE_ORPHANED?
Date: Thu, 09 Jan 2014 07:35:05 -0600 [thread overview]
Message-ID: <52CEA589.9060607@suse.de> (raw)
In-Reply-To: <20140109102301.GD10565@ZenIV.linux.org.uk>
On 01/09/2014 04:23 AM, Joel Becker wrote:
> Unlink can happen from anywhere, but only the last closing node can
> actually remove the file. MAYBE_ORPHANED tells the node to try for
> removal at close time. It is absolutely necessary.
>
The reason I asked the query is that OCFS2_INODE_MAYBE_ORPHANED is being
set at every dentry downconvert. Is this really necessary because every
dentry downconvert does not turn into unlink? (I know it says maybe :/ )
Is it okay to set it when the open_lock fails or is it too late in the
process? If another node has performed an unlink, it would need to get
the open lock before it performs the inode wipe. So we should be safe
that way? Is there anything incorrect in this design?
--
Goldwyn
next prev parent reply other threads:[~2014-01-09 13:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 0:12 [Ocfs2-devel] What's the need of OCFS2_INODE_MAYBE_ORPHANED? Goldwyn Rodrigues
2014-01-09 1:29 ` Srinivas Eeda
2014-01-09 3:12 ` Goldwyn Rodrigues
2014-01-09 5:30 ` Srinivas Eeda
2014-01-09 10:23 ` Joel Becker
2014-01-09 13:35 ` Goldwyn Rodrigues [this message]
2014-01-13 15:39 ` Joel Becker
2014-01-09 15:44 ` Goldwyn Rodrigues
2014-01-09 16:06 ` Srinivas Eeda
2014-01-09 16:34 ` Goldwyn Rodrigues
2014-01-09 17:04 ` Srinivas Eeda
2014-01-09 17:27 ` Goldwyn Rodrigues
2014-01-13 15:42 ` Joel Becker
2014-01-15 15:35 ` Goldwyn Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CEA589.9060607@suse.de \
--to=rgoldwyn@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.