diff for duplicates of <52CEF624.9020702@arm.com> diff --git a/a/1.txt b/N1/1.txt index b403941..12830d8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,10 +2,8 @@ On 08/01/14 20:27, Greg Kroah-Hartman wrote: > On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote: >> From: Sudeep Holla <sudeep.holla@arm.com> >> ->> This patch adds initial support for providing processor cache informatio= -n ->> to userspace through sysfs interface. This is based on x86 implementatio= -n +>> This patch adds initial support for providing processor cache information +>> to userspace through sysfs interface. This is based on x86 implementation >> and hence the interface is intended to be fully compatible. >> >> A per-cpu array of cache information maintained is used mainly for @@ -14,8 +12,7 @@ n >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >> --- >> drivers/base/Makefile | 2 +- ->> drivers/base/cacheinfo.c | 296 +++++++++++++++++++++++++++++++++++++++= -+++++++ +>> drivers/base/cacheinfo.c | 296 ++++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/cacheinfo.h | 43 +++++++ >> 3 files changed, 340 insertions(+), 1 deletion(-) >> create mode 100644 drivers/base/cacheinfo.c @@ -25,15 +22,15 @@ n >> index 94e8a80..76f07c8 100644 >> --- a/drivers/base/Makefile >> +++ b/drivers/base/Makefile ->> @@ -4,7 +4,7 @@ obj-y=09=09=09:=3D core.o bus.o dd.o syscore.o \ ->> =09=09=09 driver.o class.o platform.o \ ->> =09=09=09 cpu.o firmware.o init.o map.o devres.o \ ->> =09=09=09 attribute_container.o transport_class.o \ ->> -=09=09=09 topology.o ->> +=09=09=09 topology.o cacheinfo.o ->> obj-$(CONFIG_DEVTMPFS)=09+=3D devtmpfs.o ->> obj-$(CONFIG_DMA_CMA) +=3D dma-contiguous.o ->> obj-y=09=09=09+=3D power/ +>> @@ -4,7 +4,7 @@ obj-y := core.o bus.o dd.o syscore.o \ +>> driver.o class.o platform.o \ +>> cpu.o firmware.o init.o map.o devres.o \ +>> attribute_container.o transport_class.o \ +>> - topology.o +>> + topology.o cacheinfo.o +>> obj-$(CONFIG_DEVTMPFS) += devtmpfs.o +>> obj-$(CONFIG_DMA_CMA) += dma-contiguous.o +>> obj-y += power/ >> diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c >> new file mode 100644 >> index 0000000..f436c31 @@ -71,10 +68,9 @@ n >> +#include <linux/sysfs.h> >> + >> +struct cache_attr { ->> +=09struct attribute attr; ->> +=09 ssize_t(*show) (unsigned int, unsigned short, char *); ->> +=09 ssize_t(*store) (unsigned int, unsigned short, const char *, size_t= -); +>> + struct attribute attr; +>> + ssize_t(*show) (unsigned int, unsigned short, char *); +>> + ssize_t(*store) (unsigned int, unsigned short, const char *, size_t); >> +}; >> + >> +/* pointer to kobject for cpuX/cache */ @@ -82,29 +78,27 @@ n >> +#define per_cpu_cache_kobject(cpu) (per_cpu(ci_cache_kobject, cpu)) >> + >> +struct index_kobject { ->> +=09struct kobject kobj; ->> +=09unsigned int cpu; ->> +=09unsigned short index; +>> + struct kobject kobj; +>> + unsigned int cpu; +>> + unsigned short index; >> +}; >> + >> +static cpumask_t cache_dev_map; >> + >> +/* pointer to array of kobjects for cpuX/cache/indexY */ ->=20 +> > Please don't use "raw" kobjects for this, use the device attribute > groups, that's what they are there for. Bonus is that your code should > get a lot simpler when you do that. ->=20 +> -Yes I now understand device attribute group simplifies the code, but I thin= -k +Yes I now understand device attribute group simplifies the code, but I think kobjects are still needed as we need to track both cpu and cache index. By reusing only cpu device kobject, we can track cpu only. Please correct me if I am missing to understand something here. -One thought I have is to make cache_info structure common to all architectu= -re +One thought I have is to make cache_info structure common to all architecture (for now its ARM specific) and introduce kobject in that similar to ia64 implementation. That even eliminates lot of weak functions defined. diff --git a/a/content_digest b/N1/content_digest index 4772da0..b882c41 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,28 +1,18 @@ "ref\01389209168-17189-1-git-send-email-sudeep.holla@arm.com\0" "ref\01389209168-17189-2-git-send-email-sudeep.holla@arm.com\0" "ref\020140108202707.GE8417@kroah.com\0" - "From\0Sudeep Holla <Sudeep.Holla@arm.com>\0" - "Subject\0Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs\0" + "From\0Sudeep.Holla@arm.com (Sudeep Holla)\0" + "Subject\0[PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs\0" "Date\0Thu, 09 Jan 2014 19:19:00 +0000\0" - "To\0Greg Kroah-Hartman <gregkh@linuxfoundation.org>\0" - "Cc\0devicetree@vger.kernel.org <devicetree@vger.kernel.org>" - Ashok Raj <ashok.raj@intel.com> - Rob Herring <robh@kernel.org> - x86@kernel.org <x86@kernel.org> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - Sudeep.Holla@arm.com - linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> - " linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On 08/01/14 20:27, Greg Kroah-Hartman wrote:\n" "> On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote:\n" ">> From: Sudeep Holla <sudeep.holla@arm.com>\n" ">>\n" - ">> This patch adds initial support for providing processor cache informatio=\n" - "n\n" - ">> to userspace through sysfs interface. This is based on x86 implementatio=\n" - "n\n" + ">> This patch adds initial support for providing processor cache information\n" + ">> to userspace through sysfs interface. This is based on x86 implementation\n" ">> and hence the interface is intended to be fully compatible.\n" ">>\n" ">> A per-cpu array of cache information maintained is used mainly for\n" @@ -31,8 +21,7 @@ ">> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>\n" ">> ---\n" ">> drivers/base/Makefile | 2 +-\n" - ">> drivers/base/cacheinfo.c | 296 +++++++++++++++++++++++++++++++++++++++=\n" - "+++++++\n" + ">> drivers/base/cacheinfo.c | 296 ++++++++++++++++++++++++++++++++++++++++++++++\n" ">> include/linux/cacheinfo.h | 43 +++++++\n" ">> 3 files changed, 340 insertions(+), 1 deletion(-)\n" ">> create mode 100644 drivers/base/cacheinfo.c\n" @@ -42,15 +31,15 @@ ">> index 94e8a80..76f07c8 100644\n" ">> --- a/drivers/base/Makefile\n" ">> +++ b/drivers/base/Makefile\n" - ">> @@ -4,7 +4,7 @@ obj-y=09=09=09:=3D core.o bus.o dd.o syscore.o \\\n" - ">> =09=09=09 driver.o class.o platform.o \\\n" - ">> =09=09=09 cpu.o firmware.o init.o map.o devres.o \\\n" - ">> =09=09=09 attribute_container.o transport_class.o \\\n" - ">> -=09=09=09 topology.o\n" - ">> +=09=09=09 topology.o cacheinfo.o\n" - ">> obj-$(CONFIG_DEVTMPFS)=09+=3D devtmpfs.o\n" - ">> obj-$(CONFIG_DMA_CMA) +=3D dma-contiguous.o\n" - ">> obj-y=09=09=09+=3D power/\n" + ">> @@ -4,7 +4,7 @@ obj-y\t\t\t:= core.o bus.o dd.o syscore.o \\\n" + ">> \t\t\t driver.o class.o platform.o \\\n" + ">> \t\t\t cpu.o firmware.o init.o map.o devres.o \\\n" + ">> \t\t\t attribute_container.o transport_class.o \\\n" + ">> -\t\t\t topology.o\n" + ">> +\t\t\t topology.o cacheinfo.o\n" + ">> obj-$(CONFIG_DEVTMPFS)\t+= devtmpfs.o\n" + ">> obj-$(CONFIG_DMA_CMA) += dma-contiguous.o\n" + ">> obj-y\t\t\t+= power/\n" ">> diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c\n" ">> new file mode 100644\n" ">> index 0000000..f436c31\n" @@ -88,10 +77,9 @@ ">> +#include <linux/sysfs.h>\n" ">> +\n" ">> +struct cache_attr {\n" - ">> +=09struct attribute attr;\n" - ">> +=09 ssize_t(*show) (unsigned int, unsigned short, char *);\n" - ">> +=09 ssize_t(*store) (unsigned int, unsigned short, const char *, size_t=\n" - ");\n" + ">> +\tstruct attribute attr;\n" + ">> +\t ssize_t(*show) (unsigned int, unsigned short, char *);\n" + ">> +\t ssize_t(*store) (unsigned int, unsigned short, const char *, size_t);\n" ">> +};\n" ">> +\n" ">> +/* pointer to kobject for cpuX/cache */\n" @@ -99,33 +87,31 @@ ">> +#define per_cpu_cache_kobject(cpu) (per_cpu(ci_cache_kobject, cpu))\n" ">> +\n" ">> +struct index_kobject {\n" - ">> +=09struct kobject kobj;\n" - ">> +=09unsigned int cpu;\n" - ">> +=09unsigned short index;\n" + ">> +\tstruct kobject kobj;\n" + ">> +\tunsigned int cpu;\n" + ">> +\tunsigned short index;\n" ">> +};\n" ">> +\n" ">> +static cpumask_t cache_dev_map;\n" ">> +\n" ">> +/* pointer to array of kobjects for cpuX/cache/indexY */\n" - ">=20\n" + "> \n" "> Please don't use \"raw\" kobjects for this, use the device attribute\n" "> groups, that's what they are there for. Bonus is that your code should\n" "> get a lot simpler when you do that.\n" - ">=20\n" + "> \n" "\n" - "Yes I now understand device attribute group simplifies the code, but I thin=\n" - "k\n" + "Yes I now understand device attribute group simplifies the code, but I think\n" "kobjects are still needed as we need to track both cpu and cache index.\n" "By reusing only cpu device kobject, we can track cpu only.\n" "\n" "Please correct me if I am missing to understand something here.\n" "\n" - "One thought I have is to make cache_info structure common to all architectu=\n" - "re\n" + "One thought I have is to make cache_info structure common to all architecture\n" "(for now its ARM specific) and introduce kobject in that similar to ia64\n" "implementation. That even eliminates lot of weak functions defined.\n" "\n" "Regards,\n" Sudeep -5f2639470cccad44ff97e5baf1de6bcbf50522e6ae4be5070ce91f41f79b3e69 +227dcc1a6b24c13aa9622aa225da6831f3a529231863bb12f4f7945c5a90210f
diff --git a/a/1.txt b/N2/1.txt index b403941..1fa54b1 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,21 +1,18 @@ On 08/01/14 20:27, Greg Kroah-Hartman wrote: > On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote: ->> From: Sudeep Holla <sudeep.holla@arm.com> +>> From: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org> >> ->> This patch adds initial support for providing processor cache informatio= -n ->> to userspace through sysfs interface. This is based on x86 implementatio= -n +>> This patch adds initial support for providing processor cache information +>> to userspace through sysfs interface. This is based on x86 implementation >> and hence the interface is intended to be fully compatible. >> >> A per-cpu array of cache information maintained is used mainly for >> sysfs-related book keeping. >> ->> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> +>> Signed-off-by: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org> >> --- >> drivers/base/Makefile | 2 +- ->> drivers/base/cacheinfo.c | 296 +++++++++++++++++++++++++++++++++++++++= -+++++++ +>> drivers/base/cacheinfo.c | 296 ++++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/cacheinfo.h | 43 +++++++ >> 3 files changed, 340 insertions(+), 1 deletion(-) >> create mode 100644 drivers/base/cacheinfo.c @@ -25,15 +22,15 @@ n >> index 94e8a80..76f07c8 100644 >> --- a/drivers/base/Makefile >> +++ b/drivers/base/Makefile ->> @@ -4,7 +4,7 @@ obj-y=09=09=09:=3D core.o bus.o dd.o syscore.o \ ->> =09=09=09 driver.o class.o platform.o \ ->> =09=09=09 cpu.o firmware.o init.o map.o devres.o \ ->> =09=09=09 attribute_container.o transport_class.o \ ->> -=09=09=09 topology.o ->> +=09=09=09 topology.o cacheinfo.o ->> obj-$(CONFIG_DEVTMPFS)=09+=3D devtmpfs.o ->> obj-$(CONFIG_DMA_CMA) +=3D dma-contiguous.o ->> obj-y=09=09=09+=3D power/ +>> @@ -4,7 +4,7 @@ obj-y := core.o bus.o dd.o syscore.o \ +>> driver.o class.o platform.o \ +>> cpu.o firmware.o init.o map.o devres.o \ +>> attribute_container.o transport_class.o \ +>> - topology.o +>> + topology.o cacheinfo.o +>> obj-$(CONFIG_DEVTMPFS) += devtmpfs.o +>> obj-$(CONFIG_DMA_CMA) += dma-contiguous.o +>> obj-y += power/ >> diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c >> new file mode 100644 >> index 0000000..f436c31 @@ -46,7 +43,7 @@ n >> + * Copyright (C) 2013 ARM Ltd. >> + * All Rights Reserved >> + * ->> + * Author: Sudeep Holla <sudeep.holla@arm.com> +>> + * Author: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org> >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as @@ -71,10 +68,9 @@ n >> +#include <linux/sysfs.h> >> + >> +struct cache_attr { ->> +=09struct attribute attr; ->> +=09 ssize_t(*show) (unsigned int, unsigned short, char *); ->> +=09 ssize_t(*store) (unsigned int, unsigned short, const char *, size_t= -); +>> + struct attribute attr; +>> + ssize_t(*show) (unsigned int, unsigned short, char *); +>> + ssize_t(*store) (unsigned int, unsigned short, const char *, size_t); >> +}; >> + >> +/* pointer to kobject for cpuX/cache */ @@ -82,31 +78,36 @@ n >> +#define per_cpu_cache_kobject(cpu) (per_cpu(ci_cache_kobject, cpu)) >> + >> +struct index_kobject { ->> +=09struct kobject kobj; ->> +=09unsigned int cpu; ->> +=09unsigned short index; +>> + struct kobject kobj; +>> + unsigned int cpu; +>> + unsigned short index; >> +}; >> + >> +static cpumask_t cache_dev_map; >> + >> +/* pointer to array of kobjects for cpuX/cache/indexY */ ->=20 +> > Please don't use "raw" kobjects for this, use the device attribute > groups, that's what they are there for. Bonus is that your code should > get a lot simpler when you do that. ->=20 +> -Yes I now understand device attribute group simplifies the code, but I thin= -k +Yes I now understand device attribute group simplifies the code, but I think kobjects are still needed as we need to track both cpu and cache index. By reusing only cpu device kobject, we can track cpu only. Please correct me if I am missing to understand something here. -One thought I have is to make cache_info structure common to all architectu= -re +One thought I have is to make cache_info structure common to all architecture (for now its ARM specific) and introduce kobject in that similar to ia64 implementation. That even eliminates lot of weak functions defined. Regards, Sudeep + + + +-- +To unsubscribe from this list: send the line "unsubscribe devicetree" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 4772da0..0a143a9 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,38 +1,37 @@ "ref\01389209168-17189-1-git-send-email-sudeep.holla@arm.com\0" "ref\01389209168-17189-2-git-send-email-sudeep.holla@arm.com\0" "ref\020140108202707.GE8417@kroah.com\0" - "From\0Sudeep Holla <Sudeep.Holla@arm.com>\0" + "ref\020140108202707.GE8417-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org\0" + "From\0Sudeep Holla <Sudeep.Holla-5wv7dgnIgG8@public.gmane.org>\0" "Subject\0Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs\0" "Date\0Thu, 09 Jan 2014 19:19:00 +0000\0" - "To\0Greg Kroah-Hartman <gregkh@linuxfoundation.org>\0" - "Cc\0devicetree@vger.kernel.org <devicetree@vger.kernel.org>" - Ashok Raj <ashok.raj@intel.com> - Rob Herring <robh@kernel.org> - x86@kernel.org <x86@kernel.org> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - Sudeep.Holla@arm.com - linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> - " linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>\0" + "To\0Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>\0" + "Cc\0Sudeep.Holla-5wv7dgnIgG8@public.gmane.org" + x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org <x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> + linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org> + devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> + linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> + linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> + Ashok Raj <ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> + Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> + " Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>\0" "\00:1\0" "b\0" "On 08/01/14 20:27, Greg Kroah-Hartman wrote:\n" "> On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote:\n" - ">> From: Sudeep Holla <sudeep.holla@arm.com>\n" + ">> From: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>\n" ">>\n" - ">> This patch adds initial support for providing processor cache informatio=\n" - "n\n" - ">> to userspace through sysfs interface. This is based on x86 implementatio=\n" - "n\n" + ">> This patch adds initial support for providing processor cache information\n" + ">> to userspace through sysfs interface. This is based on x86 implementation\n" ">> and hence the interface is intended to be fully compatible.\n" ">>\n" ">> A per-cpu array of cache information maintained is used mainly for\n" ">> sysfs-related book keeping.\n" ">>\n" - ">> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>\n" + ">> Signed-off-by: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>\n" ">> ---\n" ">> drivers/base/Makefile | 2 +-\n" - ">> drivers/base/cacheinfo.c | 296 +++++++++++++++++++++++++++++++++++++++=\n" - "+++++++\n" + ">> drivers/base/cacheinfo.c | 296 ++++++++++++++++++++++++++++++++++++++++++++++\n" ">> include/linux/cacheinfo.h | 43 +++++++\n" ">> 3 files changed, 340 insertions(+), 1 deletion(-)\n" ">> create mode 100644 drivers/base/cacheinfo.c\n" @@ -42,15 +41,15 @@ ">> index 94e8a80..76f07c8 100644\n" ">> --- a/drivers/base/Makefile\n" ">> +++ b/drivers/base/Makefile\n" - ">> @@ -4,7 +4,7 @@ obj-y=09=09=09:=3D core.o bus.o dd.o syscore.o \\\n" - ">> =09=09=09 driver.o class.o platform.o \\\n" - ">> =09=09=09 cpu.o firmware.o init.o map.o devres.o \\\n" - ">> =09=09=09 attribute_container.o transport_class.o \\\n" - ">> -=09=09=09 topology.o\n" - ">> +=09=09=09 topology.o cacheinfo.o\n" - ">> obj-$(CONFIG_DEVTMPFS)=09+=3D devtmpfs.o\n" - ">> obj-$(CONFIG_DMA_CMA) +=3D dma-contiguous.o\n" - ">> obj-y=09=09=09+=3D power/\n" + ">> @@ -4,7 +4,7 @@ obj-y\t\t\t:= core.o bus.o dd.o syscore.o \\\n" + ">> \t\t\t driver.o class.o platform.o \\\n" + ">> \t\t\t cpu.o firmware.o init.o map.o devres.o \\\n" + ">> \t\t\t attribute_container.o transport_class.o \\\n" + ">> -\t\t\t topology.o\n" + ">> +\t\t\t topology.o cacheinfo.o\n" + ">> obj-$(CONFIG_DEVTMPFS)\t+= devtmpfs.o\n" + ">> obj-$(CONFIG_DMA_CMA) += dma-contiguous.o\n" + ">> obj-y\t\t\t+= power/\n" ">> diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c\n" ">> new file mode 100644\n" ">> index 0000000..f436c31\n" @@ -63,7 +62,7 @@ ">> + * Copyright (C) 2013 ARM Ltd.\n" ">> + * All Rights Reserved\n" ">> + *\n" - ">> + * Author: Sudeep Holla <sudeep.holla@arm.com>\n" + ">> + * Author: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>\n" ">> + *\n" ">> + * This program is free software; you can redistribute it and/or modify\n" ">> + * it under the terms of the GNU General Public License version 2 as\n" @@ -88,10 +87,9 @@ ">> +#include <linux/sysfs.h>\n" ">> +\n" ">> +struct cache_attr {\n" - ">> +=09struct attribute attr;\n" - ">> +=09 ssize_t(*show) (unsigned int, unsigned short, char *);\n" - ">> +=09 ssize_t(*store) (unsigned int, unsigned short, const char *, size_t=\n" - ");\n" + ">> +\tstruct attribute attr;\n" + ">> +\t ssize_t(*show) (unsigned int, unsigned short, char *);\n" + ">> +\t ssize_t(*store) (unsigned int, unsigned short, const char *, size_t);\n" ">> +};\n" ">> +\n" ">> +/* pointer to kobject for cpuX/cache */\n" @@ -99,33 +97,38 @@ ">> +#define per_cpu_cache_kobject(cpu) (per_cpu(ci_cache_kobject, cpu))\n" ">> +\n" ">> +struct index_kobject {\n" - ">> +=09struct kobject kobj;\n" - ">> +=09unsigned int cpu;\n" - ">> +=09unsigned short index;\n" + ">> +\tstruct kobject kobj;\n" + ">> +\tunsigned int cpu;\n" + ">> +\tunsigned short index;\n" ">> +};\n" ">> +\n" ">> +static cpumask_t cache_dev_map;\n" ">> +\n" ">> +/* pointer to array of kobjects for cpuX/cache/indexY */\n" - ">=20\n" + "> \n" "> Please don't use \"raw\" kobjects for this, use the device attribute\n" "> groups, that's what they are there for. Bonus is that your code should\n" "> get a lot simpler when you do that.\n" - ">=20\n" + "> \n" "\n" - "Yes I now understand device attribute group simplifies the code, but I thin=\n" - "k\n" + "Yes I now understand device attribute group simplifies the code, but I think\n" "kobjects are still needed as we need to track both cpu and cache index.\n" "By reusing only cpu device kobject, we can track cpu only.\n" "\n" "Please correct me if I am missing to understand something here.\n" "\n" - "One thought I have is to make cache_info structure common to all architectu=\n" - "re\n" + "One thought I have is to make cache_info structure common to all architecture\n" "(for now its ARM specific) and introduce kobject in that similar to ia64\n" "implementation. That even eliminates lot of weak functions defined.\n" "\n" "Regards,\n" - Sudeep + "Sudeep\n" + "\n" + "\n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -5f2639470cccad44ff97e5baf1de6bcbf50522e6ae4be5070ce91f41f79b3e69 +c3c7b318ace714126078704bd01913b1f2ea065b8793fe30bd6409ceb78b31f7
diff --git a/a/1.txt b/N3/1.txt index b403941..12830d8 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -2,10 +2,8 @@ On 08/01/14 20:27, Greg Kroah-Hartman wrote: > On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote: >> From: Sudeep Holla <sudeep.holla@arm.com> >> ->> This patch adds initial support for providing processor cache informatio= -n ->> to userspace through sysfs interface. This is based on x86 implementatio= -n +>> This patch adds initial support for providing processor cache information +>> to userspace through sysfs interface. This is based on x86 implementation >> and hence the interface is intended to be fully compatible. >> >> A per-cpu array of cache information maintained is used mainly for @@ -14,8 +12,7 @@ n >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >> --- >> drivers/base/Makefile | 2 +- ->> drivers/base/cacheinfo.c | 296 +++++++++++++++++++++++++++++++++++++++= -+++++++ +>> drivers/base/cacheinfo.c | 296 ++++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/cacheinfo.h | 43 +++++++ >> 3 files changed, 340 insertions(+), 1 deletion(-) >> create mode 100644 drivers/base/cacheinfo.c @@ -25,15 +22,15 @@ n >> index 94e8a80..76f07c8 100644 >> --- a/drivers/base/Makefile >> +++ b/drivers/base/Makefile ->> @@ -4,7 +4,7 @@ obj-y=09=09=09:=3D core.o bus.o dd.o syscore.o \ ->> =09=09=09 driver.o class.o platform.o \ ->> =09=09=09 cpu.o firmware.o init.o map.o devres.o \ ->> =09=09=09 attribute_container.o transport_class.o \ ->> -=09=09=09 topology.o ->> +=09=09=09 topology.o cacheinfo.o ->> obj-$(CONFIG_DEVTMPFS)=09+=3D devtmpfs.o ->> obj-$(CONFIG_DMA_CMA) +=3D dma-contiguous.o ->> obj-y=09=09=09+=3D power/ +>> @@ -4,7 +4,7 @@ obj-y := core.o bus.o dd.o syscore.o \ +>> driver.o class.o platform.o \ +>> cpu.o firmware.o init.o map.o devres.o \ +>> attribute_container.o transport_class.o \ +>> - topology.o +>> + topology.o cacheinfo.o +>> obj-$(CONFIG_DEVTMPFS) += devtmpfs.o +>> obj-$(CONFIG_DMA_CMA) += dma-contiguous.o +>> obj-y += power/ >> diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c >> new file mode 100644 >> index 0000000..f436c31 @@ -71,10 +68,9 @@ n >> +#include <linux/sysfs.h> >> + >> +struct cache_attr { ->> +=09struct attribute attr; ->> +=09 ssize_t(*show) (unsigned int, unsigned short, char *); ->> +=09 ssize_t(*store) (unsigned int, unsigned short, const char *, size_t= -); +>> + struct attribute attr; +>> + ssize_t(*show) (unsigned int, unsigned short, char *); +>> + ssize_t(*store) (unsigned int, unsigned short, const char *, size_t); >> +}; >> + >> +/* pointer to kobject for cpuX/cache */ @@ -82,29 +78,27 @@ n >> +#define per_cpu_cache_kobject(cpu) (per_cpu(ci_cache_kobject, cpu)) >> + >> +struct index_kobject { ->> +=09struct kobject kobj; ->> +=09unsigned int cpu; ->> +=09unsigned short index; +>> + struct kobject kobj; +>> + unsigned int cpu; +>> + unsigned short index; >> +}; >> + >> +static cpumask_t cache_dev_map; >> + >> +/* pointer to array of kobjects for cpuX/cache/indexY */ ->=20 +> > Please don't use "raw" kobjects for this, use the device attribute > groups, that's what they are there for. Bonus is that your code should > get a lot simpler when you do that. ->=20 +> -Yes I now understand device attribute group simplifies the code, but I thin= -k +Yes I now understand device attribute group simplifies the code, but I think kobjects are still needed as we need to track both cpu and cache index. By reusing only cpu device kobject, we can track cpu only. Please correct me if I am missing to understand something here. -One thought I have is to make cache_info structure common to all architectu= -re +One thought I have is to make cache_info structure common to all architecture (for now its ARM specific) and introduce kobject in that similar to ia64 implementation. That even eliminates lot of weak functions defined. diff --git a/a/content_digest b/N3/content_digest index 4772da0..2558ef6 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -5,24 +5,23 @@ "Subject\0Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs\0" "Date\0Thu, 09 Jan 2014 19:19:00 +0000\0" "To\0Greg Kroah-Hartman <gregkh@linuxfoundation.org>\0" - "Cc\0devicetree@vger.kernel.org <devicetree@vger.kernel.org>" - Ashok Raj <ashok.raj@intel.com> - Rob Herring <robh@kernel.org> + "Cc\0Sudeep.Holla@arm.com" x86@kernel.org <x86@kernel.org> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - Sudeep.Holla@arm.com linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> - " linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>\0" + devicetree@vger.kernel.org <devicetree@vger.kernel.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + Ashok Raj <ashok.raj@intel.com> + Benjamin Herrenschmidt <benh@kernel.crashing.org> + " Rob Herring <robh@kernel.org>\0" "\00:1\0" "b\0" "On 08/01/14 20:27, Greg Kroah-Hartman wrote:\n" "> On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote:\n" ">> From: Sudeep Holla <sudeep.holla@arm.com>\n" ">>\n" - ">> This patch adds initial support for providing processor cache informatio=\n" - "n\n" - ">> to userspace through sysfs interface. This is based on x86 implementatio=\n" - "n\n" + ">> This patch adds initial support for providing processor cache information\n" + ">> to userspace through sysfs interface. This is based on x86 implementation\n" ">> and hence the interface is intended to be fully compatible.\n" ">>\n" ">> A per-cpu array of cache information maintained is used mainly for\n" @@ -31,8 +30,7 @@ ">> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>\n" ">> ---\n" ">> drivers/base/Makefile | 2 +-\n" - ">> drivers/base/cacheinfo.c | 296 +++++++++++++++++++++++++++++++++++++++=\n" - "+++++++\n" + ">> drivers/base/cacheinfo.c | 296 ++++++++++++++++++++++++++++++++++++++++++++++\n" ">> include/linux/cacheinfo.h | 43 +++++++\n" ">> 3 files changed, 340 insertions(+), 1 deletion(-)\n" ">> create mode 100644 drivers/base/cacheinfo.c\n" @@ -42,15 +40,15 @@ ">> index 94e8a80..76f07c8 100644\n" ">> --- a/drivers/base/Makefile\n" ">> +++ b/drivers/base/Makefile\n" - ">> @@ -4,7 +4,7 @@ obj-y=09=09=09:=3D core.o bus.o dd.o syscore.o \\\n" - ">> =09=09=09 driver.o class.o platform.o \\\n" - ">> =09=09=09 cpu.o firmware.o init.o map.o devres.o \\\n" - ">> =09=09=09 attribute_container.o transport_class.o \\\n" - ">> -=09=09=09 topology.o\n" - ">> +=09=09=09 topology.o cacheinfo.o\n" - ">> obj-$(CONFIG_DEVTMPFS)=09+=3D devtmpfs.o\n" - ">> obj-$(CONFIG_DMA_CMA) +=3D dma-contiguous.o\n" - ">> obj-y=09=09=09+=3D power/\n" + ">> @@ -4,7 +4,7 @@ obj-y\t\t\t:= core.o bus.o dd.o syscore.o \\\n" + ">> \t\t\t driver.o class.o platform.o \\\n" + ">> \t\t\t cpu.o firmware.o init.o map.o devres.o \\\n" + ">> \t\t\t attribute_container.o transport_class.o \\\n" + ">> -\t\t\t topology.o\n" + ">> +\t\t\t topology.o cacheinfo.o\n" + ">> obj-$(CONFIG_DEVTMPFS)\t+= devtmpfs.o\n" + ">> obj-$(CONFIG_DMA_CMA) += dma-contiguous.o\n" + ">> obj-y\t\t\t+= power/\n" ">> diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c\n" ">> new file mode 100644\n" ">> index 0000000..f436c31\n" @@ -88,10 +86,9 @@ ">> +#include <linux/sysfs.h>\n" ">> +\n" ">> +struct cache_attr {\n" - ">> +=09struct attribute attr;\n" - ">> +=09 ssize_t(*show) (unsigned int, unsigned short, char *);\n" - ">> +=09 ssize_t(*store) (unsigned int, unsigned short, const char *, size_t=\n" - ");\n" + ">> +\tstruct attribute attr;\n" + ">> +\t ssize_t(*show) (unsigned int, unsigned short, char *);\n" + ">> +\t ssize_t(*store) (unsigned int, unsigned short, const char *, size_t);\n" ">> +};\n" ">> +\n" ">> +/* pointer to kobject for cpuX/cache */\n" @@ -99,33 +96,31 @@ ">> +#define per_cpu_cache_kobject(cpu) (per_cpu(ci_cache_kobject, cpu))\n" ">> +\n" ">> +struct index_kobject {\n" - ">> +=09struct kobject kobj;\n" - ">> +=09unsigned int cpu;\n" - ">> +=09unsigned short index;\n" + ">> +\tstruct kobject kobj;\n" + ">> +\tunsigned int cpu;\n" + ">> +\tunsigned short index;\n" ">> +};\n" ">> +\n" ">> +static cpumask_t cache_dev_map;\n" ">> +\n" ">> +/* pointer to array of kobjects for cpuX/cache/indexY */\n" - ">=20\n" + "> \n" "> Please don't use \"raw\" kobjects for this, use the device attribute\n" "> groups, that's what they are there for. Bonus is that your code should\n" "> get a lot simpler when you do that.\n" - ">=20\n" + "> \n" "\n" - "Yes I now understand device attribute group simplifies the code, but I thin=\n" - "k\n" + "Yes I now understand device attribute group simplifies the code, but I think\n" "kobjects are still needed as we need to track both cpu and cache index.\n" "By reusing only cpu device kobject, we can track cpu only.\n" "\n" "Please correct me if I am missing to understand something here.\n" "\n" - "One thought I have is to make cache_info structure common to all architectu=\n" - "re\n" + "One thought I have is to make cache_info structure common to all architecture\n" "(for now its ARM specific) and introduce kobject in that similar to ia64\n" "implementation. That even eliminates lot of weak functions defined.\n" "\n" "Regards,\n" Sudeep -5f2639470cccad44ff97e5baf1de6bcbf50522e6ae4be5070ce91f41f79b3e69 +ff34954305ac5fac30f9730b35c4adcfd4e45055cbecc9311c17d42a5b4538ab
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.