From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from service87.mimecast.com (service87.mimecast.com [91.220.42.44]) by ozlabs.org (Postfix) with ESMTP id 1709B2C00B0 for ; Fri, 10 Jan 2014 06:18:57 +1100 (EST) Message-ID: <52CEF624.9020702@arm.com> Date: Thu, 09 Jan 2014 19:19:00 +0000 From: Sudeep Holla MIME-Version: 1.0 To: Greg Kroah-Hartman Subject: Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs References: <1389209168-17189-1-git-send-email-sudeep.holla@arm.com> <1389209168-17189-2-git-send-email-sudeep.holla@arm.com> <20140108202707.GE8417@kroah.com> In-Reply-To: <20140108202707.GE8417@kroah.com> Content-Type: text/plain; charset=WINDOWS-1252 Cc: "devicetree@vger.kernel.org" , Ashok Raj , Rob Herring , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Sudeep.Holla@arm.com, "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/01/14 20:27, Greg Kroah-Hartman wrote: > On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote: >> From: Sudeep Holla >> >> This patch adds initial support for providing processor cache informatio= n >> to userspace through sysfs interface. This is based on x86 implementatio= n >> and hence the interface is intended to be fully compatible. >> >> A per-cpu array of cache information maintained is used mainly for >> sysfs-related book keeping. >> >> Signed-off-by: Sudeep Holla >> --- >> drivers/base/Makefile | 2 +- >> drivers/base/cacheinfo.c | 296 +++++++++++++++++++++++++++++++++++++++= +++++++ >> include/linux/cacheinfo.h | 43 +++++++ >> 3 files changed, 340 insertions(+), 1 deletion(-) >> create mode 100644 drivers/base/cacheinfo.c >> create mode 100644 include/linux/cacheinfo.h >> >> diff --git a/drivers/base/Makefile b/drivers/base/Makefile >> index 94e8a80..76f07c8 100644 >> --- a/drivers/base/Makefile >> +++ b/drivers/base/Makefile >> @@ -4,7 +4,7 @@ obj-y=09=09=09:=3D core.o bus.o dd.o syscore.o \ >> =09=09=09 driver.o class.o platform.o \ >> =09=09=09 cpu.o firmware.o init.o map.o devres.o \ >> =09=09=09 attribute_container.o transport_class.o \ >> -=09=09=09 topology.o >> +=09=09=09 topology.o cacheinfo.o >> obj-$(CONFIG_DEVTMPFS)=09+=3D devtmpfs.o >> obj-$(CONFIG_DMA_CMA) +=3D dma-contiguous.o >> obj-y=09=09=09+=3D power/ >> diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c >> new file mode 100644 >> index 0000000..f436c31 >> --- /dev/null >> +++ b/drivers/base/cacheinfo.c >> @@ -0,0 +1,296 @@ >> +/* >> + * cacheinfo support - processor cache information via sysfs >> + * >> + * Copyright (C) 2013 ARM Ltd. >> + * All Rights Reserved >> + * >> + * Author: Sudeep Holla >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + * >> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any >> + * kind, whether express or implied; without even the implied warranty >> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +struct cache_attr { >> +=09struct attribute attr; >> +=09 ssize_t(*show) (unsigned int, unsigned short, char *); >> +=09 ssize_t(*store) (unsigned int, unsigned short, const char *, size_t= ); >> +}; >> + >> +/* pointer to kobject for cpuX/cache */ >> +static DEFINE_PER_CPU(struct kobject *, ci_cache_kobject); >> +#define per_cpu_cache_kobject(cpu) (per_cpu(ci_cache_kobject, cpu)) >> + >> +struct index_kobject { >> +=09struct kobject kobj; >> +=09unsigned int cpu; >> +=09unsigned short index; >> +}; >> + >> +static cpumask_t cache_dev_map; >> + >> +/* pointer to array of kobjects for cpuX/cache/indexY */ >=20 > Please don't use "raw" kobjects for this, use the device attribute > groups, that's what they are there for. Bonus is that your code should > get a lot simpler when you do that. >=20 Yes I now understand device attribute group simplifies the code, but I thin= k kobjects are still needed as we need to track both cpu and cache index. By reusing only cpu device kobject, we can track cpu only. Please correct me if I am missing to understand something here. One thought I have is to make cache_info structure common to all architectu= re (for now its ARM specific) and introduce kobject in that similar to ia64 implementation. That even eliminates lot of weak functions defined. Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep.Holla@arm.com (Sudeep Holla) Date: Thu, 09 Jan 2014 19:19:00 +0000 Subject: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs In-Reply-To: <20140108202707.GE8417@kroah.com> References: <1389209168-17189-1-git-send-email-sudeep.holla@arm.com> <1389209168-17189-2-git-send-email-sudeep.holla@arm.com> <20140108202707.GE8417@kroah.com> Message-ID: <52CEF624.9020702@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/01/14 20:27, Greg Kroah-Hartman wrote: > On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote: >> From: Sudeep Holla >> >> This patch adds initial support for providing processor cache information >> to userspace through sysfs interface. This is based on x86 implementation >> and hence the interface is intended to be fully compatible. >> >> A per-cpu array of cache information maintained is used mainly for >> sysfs-related book keeping. >> >> Signed-off-by: Sudeep Holla >> --- >> drivers/base/Makefile | 2 +- >> drivers/base/cacheinfo.c | 296 ++++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/cacheinfo.h | 43 +++++++ >> 3 files changed, 340 insertions(+), 1 deletion(-) >> create mode 100644 drivers/base/cacheinfo.c >> create mode 100644 include/linux/cacheinfo.h >> >> diff --git a/drivers/base/Makefile b/drivers/base/Makefile >> index 94e8a80..76f07c8 100644 >> --- a/drivers/base/Makefile >> +++ b/drivers/base/Makefile >> @@ -4,7 +4,7 @@ obj-y := core.o bus.o dd.o syscore.o \ >> driver.o class.o platform.o \ >> cpu.o firmware.o init.o map.o devres.o \ >> attribute_container.o transport_class.o \ >> - topology.o >> + topology.o cacheinfo.o >> obj-$(CONFIG_DEVTMPFS) += devtmpfs.o >> obj-$(CONFIG_DMA_CMA) += dma-contiguous.o >> obj-y += power/ >> diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c >> new file mode 100644 >> index 0000000..f436c31 >> --- /dev/null >> +++ b/drivers/base/cacheinfo.c >> @@ -0,0 +1,296 @@ >> +/* >> + * cacheinfo support - processor cache information via sysfs >> + * >> + * Copyright (C) 2013 ARM Ltd. >> + * All Rights Reserved >> + * >> + * Author: Sudeep Holla >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + * >> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any >> + * kind, whether express or implied; without even the implied warranty >> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +struct cache_attr { >> + struct attribute attr; >> + ssize_t(*show) (unsigned int, unsigned short, char *); >> + ssize_t(*store) (unsigned int, unsigned short, const char *, size_t); >> +}; >> + >> +/* pointer to kobject for cpuX/cache */ >> +static DEFINE_PER_CPU(struct kobject *, ci_cache_kobject); >> +#define per_cpu_cache_kobject(cpu) (per_cpu(ci_cache_kobject, cpu)) >> + >> +struct index_kobject { >> + struct kobject kobj; >> + unsigned int cpu; >> + unsigned short index; >> +}; >> + >> +static cpumask_t cache_dev_map; >> + >> +/* pointer to array of kobjects for cpuX/cache/indexY */ > > Please don't use "raw" kobjects for this, use the device attribute > groups, that's what they are there for. Bonus is that your code should > get a lot simpler when you do that. > Yes I now understand device attribute group simplifies the code, but I think kobjects are still needed as we need to track both cpu and cache index. By reusing only cpu device kobject, we can track cpu only. Please correct me if I am missing to understand something here. One thought I have is to make cache_info structure common to all architecture (for now its ARM specific) and introduce kobject in that similar to ia64 implementation. That even eliminates lot of weak functions defined. Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs Date: Thu, 09 Jan 2014 19:19:00 +0000 Message-ID: <52CEF624.9020702@arm.com> References: <1389209168-17189-1-git-send-email-sudeep.holla@arm.com> <1389209168-17189-2-git-send-email-sudeep.holla@arm.com> <20140108202707.GE8417@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20140108202707.GE8417-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg Kroah-Hartman Cc: Sudeep.Holla-5wv7dgnIgG8@public.gmane.org, "x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Ashok Raj , Benjamin Herrenschmidt , Rob Herring List-Id: devicetree@vger.kernel.org On 08/01/14 20:27, Greg Kroah-Hartman wrote: > On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote: >> From: Sudeep Holla >> >> This patch adds initial support for providing processor cache information >> to userspace through sysfs interface. This is based on x86 implementation >> and hence the interface is intended to be fully compatible. >> >> A per-cpu array of cache information maintained is used mainly for >> sysfs-related book keeping. >> >> Signed-off-by: Sudeep Holla >> --- >> drivers/base/Makefile | 2 +- >> drivers/base/cacheinfo.c | 296 ++++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/cacheinfo.h | 43 +++++++ >> 3 files changed, 340 insertions(+), 1 deletion(-) >> create mode 100644 drivers/base/cacheinfo.c >> create mode 100644 include/linux/cacheinfo.h >> >> diff --git a/drivers/base/Makefile b/drivers/base/Makefile >> index 94e8a80..76f07c8 100644 >> --- a/drivers/base/Makefile >> +++ b/drivers/base/Makefile >> @@ -4,7 +4,7 @@ obj-y := core.o bus.o dd.o syscore.o \ >> driver.o class.o platform.o \ >> cpu.o firmware.o init.o map.o devres.o \ >> attribute_container.o transport_class.o \ >> - topology.o >> + topology.o cacheinfo.o >> obj-$(CONFIG_DEVTMPFS) += devtmpfs.o >> obj-$(CONFIG_DMA_CMA) += dma-contiguous.o >> obj-y += power/ >> diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c >> new file mode 100644 >> index 0000000..f436c31 >> --- /dev/null >> +++ b/drivers/base/cacheinfo.c >> @@ -0,0 +1,296 @@ >> +/* >> + * cacheinfo support - processor cache information via sysfs >> + * >> + * Copyright (C) 2013 ARM Ltd. >> + * All Rights Reserved >> + * >> + * Author: Sudeep Holla >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + * >> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any >> + * kind, whether express or implied; without even the implied warranty >> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +struct cache_attr { >> + struct attribute attr; >> + ssize_t(*show) (unsigned int, unsigned short, char *); >> + ssize_t(*store) (unsigned int, unsigned short, const char *, size_t); >> +}; >> + >> +/* pointer to kobject for cpuX/cache */ >> +static DEFINE_PER_CPU(struct kobject *, ci_cache_kobject); >> +#define per_cpu_cache_kobject(cpu) (per_cpu(ci_cache_kobject, cpu)) >> + >> +struct index_kobject { >> + struct kobject kobj; >> + unsigned int cpu; >> + unsigned short index; >> +}; >> + >> +static cpumask_t cache_dev_map; >> + >> +/* pointer to array of kobjects for cpuX/cache/indexY */ > > Please don't use "raw" kobjects for this, use the device attribute > groups, that's what they are there for. Bonus is that your code should > get a lot simpler when you do that. > Yes I now understand device attribute group simplifies the code, but I think kobjects are still needed as we need to track both cpu and cache index. By reusing only cpu device kobject, we can track cpu only. Please correct me if I am missing to understand something here. One thought I have is to make cache_info structure common to all architecture (for now its ARM specific) and introduce kobject in that similar to ia64 implementation. That even eliminates lot of weak functions defined. Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757139AbaAITTD (ORCPT ); Thu, 9 Jan 2014 14:19:03 -0500 Received: from service87.mimecast.com ([91.220.42.44]:46364 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756316AbaAITS4 convert rfc822-to-8bit (ORCPT ); Thu, 9 Jan 2014 14:18:56 -0500 Message-ID: <52CEF624.9020702@arm.com> Date: Thu, 09 Jan 2014 19:19:00 +0000 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: Sudeep.Holla@arm.com, "x86@kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Ashok Raj , Benjamin Herrenschmidt , Rob Herring Subject: Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs References: <1389209168-17189-1-git-send-email-sudeep.holla@arm.com> <1389209168-17189-2-git-send-email-sudeep.holla@arm.com> <20140108202707.GE8417@kroah.com> In-Reply-To: <20140108202707.GE8417@kroah.com> X-OriginalArrivalTime: 09 Jan 2014 19:18:53.0182 (UTC) FILETIME=[A24251E0:01CF0D6F] X-MC-Unique: 114010919185500201 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/01/14 20:27, Greg Kroah-Hartman wrote: > On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote: >> From: Sudeep Holla >> >> This patch adds initial support for providing processor cache information >> to userspace through sysfs interface. This is based on x86 implementation >> and hence the interface is intended to be fully compatible. >> >> A per-cpu array of cache information maintained is used mainly for >> sysfs-related book keeping. >> >> Signed-off-by: Sudeep Holla >> --- >> drivers/base/Makefile | 2 +- >> drivers/base/cacheinfo.c | 296 ++++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/cacheinfo.h | 43 +++++++ >> 3 files changed, 340 insertions(+), 1 deletion(-) >> create mode 100644 drivers/base/cacheinfo.c >> create mode 100644 include/linux/cacheinfo.h >> >> diff --git a/drivers/base/Makefile b/drivers/base/Makefile >> index 94e8a80..76f07c8 100644 >> --- a/drivers/base/Makefile >> +++ b/drivers/base/Makefile >> @@ -4,7 +4,7 @@ obj-y := core.o bus.o dd.o syscore.o \ >> driver.o class.o platform.o \ >> cpu.o firmware.o init.o map.o devres.o \ >> attribute_container.o transport_class.o \ >> - topology.o >> + topology.o cacheinfo.o >> obj-$(CONFIG_DEVTMPFS) += devtmpfs.o >> obj-$(CONFIG_DMA_CMA) += dma-contiguous.o >> obj-y += power/ >> diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c >> new file mode 100644 >> index 0000000..f436c31 >> --- /dev/null >> +++ b/drivers/base/cacheinfo.c >> @@ -0,0 +1,296 @@ >> +/* >> + * cacheinfo support - processor cache information via sysfs >> + * >> + * Copyright (C) 2013 ARM Ltd. >> + * All Rights Reserved >> + * >> + * Author: Sudeep Holla >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + * >> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any >> + * kind, whether express or implied; without even the implied warranty >> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +struct cache_attr { >> + struct attribute attr; >> + ssize_t(*show) (unsigned int, unsigned short, char *); >> + ssize_t(*store) (unsigned int, unsigned short, const char *, size_t); >> +}; >> + >> +/* pointer to kobject for cpuX/cache */ >> +static DEFINE_PER_CPU(struct kobject *, ci_cache_kobject); >> +#define per_cpu_cache_kobject(cpu) (per_cpu(ci_cache_kobject, cpu)) >> + >> +struct index_kobject { >> + struct kobject kobj; >> + unsigned int cpu; >> + unsigned short index; >> +}; >> + >> +static cpumask_t cache_dev_map; >> + >> +/* pointer to array of kobjects for cpuX/cache/indexY */ > > Please don't use "raw" kobjects for this, use the device attribute > groups, that's what they are there for. Bonus is that your code should > get a lot simpler when you do that. > Yes I now understand device attribute group simplifies the code, but I think kobjects are still needed as we need to track both cpu and cache index. By reusing only cpu device kobject, we can track cpu only. Please correct me if I am missing to understand something here. One thought I have is to make cache_info structure common to all architecture (for now its ARM specific) and introduce kobject in that similar to ia64 implementation. That even eliminates lot of weak functions defined. Regards, Sudeep