From: John Stultz <john.stultz@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Colin Cross <ccross@android.com>,
Jesse Barker <jesse.barker@arm.com>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH 0/2] ION dummy driver
Date: Thu, 09 Jan 2014 20:54:10 -0800 [thread overview]
Message-ID: <52CF7CF2.5070002@linaro.org> (raw)
In-Reply-To: <20140110042357.GA4031@kroah.com>
On 01/09/2014 08:23 PM, Greg KH wrote:
> On Thu, Jan 09, 2014 at 07:40:53PM -0800, John Stultz wrote:
>> Greg: I realize this is after the usual -rc6 cutoff for staging,
>> so no pressure if you want to defer this for 3.15, but I saw you've
>> picked up a few things recently, so I figured I'd send it out so
>> I'm not just sitting on it while we wait for LCA to finish.
> I would have merged it, but I just tried and got a ton of errors when
> building:
>
> ERROR: "ion_device_destroy" [drivers/staging/android/ion/ion_dummy_driver.ko] undefined!
> ERROR: "ion_heap_destroy" [drivers/staging/android/ion/ion_dummy_driver.ko] undefined!
> ERROR: "ion_device_add_heap" [drivers/staging/android/ion/ion_dummy_driver.ko] undefined!
> ERROR: "ion_heap_create" [drivers/staging/android/ion/ion_dummy_driver.ko] undefined!
> ERROR: "ion_device_create" [drivers/staging/android/ion/ion_dummy_driver.ko] undefined!
>
> So, I'll just drop these patches and forget you ever sent them to me :)
Gah. Modules bite me every time! Should have been a bool and not
tristate in the Kconfig.
Sorry! I appreciate the heads up and the build related amnesia. :)
thanks
-john
prev parent reply other threads:[~2014-01-10 4:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 3:40 [PATCH 0/2] ION dummy driver John Stultz
2014-01-10 3:40 ` [PATCH 1/2] ion: Add dummy driver for testing John Stultz
2014-01-10 3:40 ` [PATCH 2/2] ion: Add carveout and chunk heaps to dummy driver John Stultz
2014-01-10 4:23 ` [PATCH 0/2] ION " Greg KH
2014-01-10 4:54 ` John Stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CF7CF2.5070002@linaro.org \
--to=john.stultz@linaro.org \
--cc=ccross@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=jesse.barker@arm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.