From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1Xet-0005w3-46 for qemu-devel@nongnu.org; Fri, 10 Jan 2014 03:41:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1Xel-0004Vm-DH for qemu-devel@nongnu.org; Fri, 10 Jan 2014 03:41:39 -0500 Received: from mail-pd0-f175.google.com ([209.85.192.175]:59490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1Xel-0004Tf-6j for qemu-devel@nongnu.org; Fri, 10 Jan 2014 03:41:31 -0500 Received: by mail-pd0-f175.google.com with SMTP id r10so343556pdi.34 for ; Fri, 10 Jan 2014 00:41:29 -0800 (PST) Message-ID: <52CFB234.5090302@ozlabs.ru> Date: Fri, 10 Jan 2014 19:41:24 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1387766542-3184-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1387766542-3184-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-ppc: disable unsupported modes for SPR_CTRL/SPR_UCTRL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, Alexander Graf On 12/23/2013 01:42 PM, Alexey Kardashevskiy wrote: > The Figure 17 "SPR encodings" of the PowerISA 2.07 describes CTRL SPR as: > > priviledged > # spr5-9 spr0-4 name mtspr mfspr len cat > 136 00100 01000 CTRL - no 32 S > 152 00100 11000 CTRL yes - 32 S > > According to this chart, the hypervisor's CTRL (#152) does not support > reading, the user-space's CTRL (UCTRL, #136) does not support writing. > > This replaces unsupported operations with the default SPR_NOACCESS hook. > > Signed-off-by: Alexey Kardashevskiy > --- > > While we are on this topic, I thought it makes sense to fix this too. > This does not seem to affect anything in the current QEMU but it is more > correct/clean. Alex, ping. Is it complicated or controversial patch? :) > > > --- > target-ppc/translate_init.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > index 93ad762..860e241 100644 > --- a/target-ppc/translate_init.c > +++ b/target-ppc/translate_init.c > @@ -6737,11 +6737,11 @@ static void init_proc_970FX (CPUPPCState *env) > 0x00000000); > spr_register(env, SPR_CTRL, "SPR_CTRL", > SPR_NOACCESS, SPR_NOACCESS, > - &spr_read_generic, &spr_write_generic, > + SPR_NOACCESS, &spr_write_generic, > 0x00000000); > spr_register(env, SPR_UCTRL, "SPR_UCTRL", > SPR_NOACCESS, SPR_NOACCESS, > - &spr_read_generic, &spr_write_generic, > + &spr_read_generic, SPR_NOACCESS, > 0x00000000); > spr_register(env, SPR_VRSAVE, "SPR_VRSAVE", > &spr_read_generic, &spr_write_generic, > @@ -6902,11 +6902,11 @@ static void init_proc_power5plus(CPUPPCState *env) > 0x00000000); > spr_register(env, SPR_CTRL, "SPR_CTRL", > SPR_NOACCESS, SPR_NOACCESS, > - &spr_read_generic, &spr_write_generic, > + SPR_NOACCESS, &spr_write_generic, > 0x00000000); > spr_register(env, SPR_UCTRL, "SPR_UCTRL", > SPR_NOACCESS, SPR_NOACCESS, > - &spr_read_generic, &spr_write_generic, > + &spr_read_generic, SPR_NOACCESS, > 0x00000000); > spr_register(env, SPR_VRSAVE, "SPR_VRSAVE", > &spr_read_generic, &spr_write_generic, > @@ -7002,11 +7002,11 @@ static void init_proc_POWER7 (CPUPPCState *env) > /* XXX : not implemented */ > spr_register(env, SPR_CTRL, "SPR_CTRLT", > SPR_NOACCESS, SPR_NOACCESS, > - &spr_read_generic, &spr_write_generic, > + SPR_NOACCESS, &spr_write_generic, > 0x80800000); > spr_register(env, SPR_UCTRL, "SPR_CTRLF", > SPR_NOACCESS, SPR_NOACCESS, > - &spr_read_generic, &spr_write_generic, > + &spr_read_generic, SPR_NOACCESS, > 0x80800000); > spr_register(env, SPR_VRSAVE, "SPR_VRSAVE", > &spr_read_generic, &spr_write_generic, > -- Alexey