From: Ian Abbott <abbotti@mev.co.uk>
To: Chase Southwood <chase.southwood@yahoo.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Ian Abbott <ian.abbott@mev.co.uk>,
"hsweeten@visionengravers.com" <hsweeten@visionengravers.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH] Staging: comedi: fix spacing coding style issue in 8255.c.
Date: Fri, 10 Jan 2014 10:34:03 +0000 [thread overview]
Message-ID: <52CFCC9B.2090204@mev.co.uk> (raw)
In-Reply-To: <1389326381-8526-1-git-send-email-chase.southwood@yahoo.com>
On 2014-01-10 03:59, Chase Southwood wrote:
> This patch for 8255.c fixes a spacing warning found by checkpatch.pl.
>
> Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
> ---
> drivers/staging/comedi/drivers/8255.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/8255.c b/drivers/staging/comedi/drivers/8255.c
> index b4009e8..48817f0 100644
> --- a/drivers/staging/comedi/drivers/8255.c
> +++ b/drivers/staging/comedi/drivers/8255.c
> @@ -94,7 +94,7 @@ I/O port base address can be found in the output of 'lspci -v'.
>
> struct subdev_8255_private {
> unsigned long iobase;
> - int (*io) (int, int, int, unsigned long);
> + int (*io)(int, int, int, unsigned long);
> };
>
> static int subdev_8255_io(int dir, int port, int data, unsigned long iobase)
> @@ -262,7 +262,7 @@ static int subdev_8255_cancel(struct comedi_device *dev,
> }
>
> int subdev_8255_init(struct comedi_device *dev, struct comedi_subdevice *s,
> - int (*io) (int, int, int, unsigned long),
> + int (*io)(int, int, int, unsigned long),
> unsigned long iobase)
> {
> struct subdev_8255_private *spriv;
> @@ -289,7 +289,7 @@ int subdev_8255_init(struct comedi_device *dev, struct comedi_subdevice *s,
> EXPORT_SYMBOL_GPL(subdev_8255_init);
>
> int subdev_8255_init_irq(struct comedi_device *dev, struct comedi_subdevice *s,
> - int (*io) (int, int, int, unsigned long),
> + int (*io)(int, int, int, unsigned long),
> unsigned long iobase)
> {
> int ret;
>
Harmless. (Good!)
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
prev parent reply other threads:[~2014-01-10 10:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 3:59 [PATCH] Staging: comedi: fix spacing coding style issue in 8255.c Chase Southwood
2014-01-10 10:34 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CFCC9B.2090204@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=chase.southwood@yahoo.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.