From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: clk_get() returns error code on failure
Date: Fri, 10 Jan 2014 11:36:10 +0000 [thread overview]
Message-ID: <52CFDB2A.1030103@codethink.co.uk> (raw)
In-Reply-To: <1389281623-10253-1-git-send-email-ben.dooks@codethink.co.uk>
On 10/01/14 01:23, Simon Horman wrote:
> On Thu, Jan 09, 2014 at 06:42:38PM +0100, Laurent Pinchart wrote:
>> Hi Ben,
>>
>> Thank you for the patch.
>>
>> On Thursday 09 January 2014 15:33:43 Ben Dooks wrote:
>>> The lager_add_standard_devices() function calls clk_get() but then fails
>>> to check that it returns an error pointer instead of NULL on failure.
>>>
>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>> Reviewed-by: Ian Molton <ian.molton@codethink.co.uk>
>>
>> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>
>> Do you plan to submit a similar patch for board-koelsch-reference.c ? I don't
>> mind doing it.
>
> Hi Ben,
>
> does this fix a problem that you have obvserved in practice.
> If so it might be worth trying to get it included as a fix
> for v3.14 rather than queueing it up for v3.15.
>
> Regardless, as it is a fix of sorts, could you please include some
> information along the following lines in the changelog:
>
> ----
> This problem has been present since xyz was added by
> deadbeef0123456789f ("ARM: shmobile: lager: something goes here")
> in v3.1X-rcY.
> ----
Ok, will update. However it is not actually a bug we've noticed
yet, just an observation whilst hunting down other issues.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-01-10 11:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 15:33 [PATCH] ARM: shmobile: clk_get() returns error code on failure Ben Dooks
2014-01-09 17:42 ` Laurent Pinchart
2014-01-10 1:23 ` Simon Horman
2014-01-10 11:36 ` Ben Dooks [this message]
2014-01-13 0:12 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CFDB2A.1030103@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.