From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org
Cc: plagnioj@jcrosoft.com
Subject: Re: [PATCH v4] video: add OpenCores VGA/LCD framebuffer driver
Date: Fri, 10 Jan 2014 12:08:27 +0000 [thread overview]
Message-ID: <52CFE2BB.8090004@ti.com> (raw)
In-Reply-To: <1385739911-6541-1-git-send-email-stefan.kristiansson@saunalahti.fi>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
Hi,
On 2013-11-29 17:45, Stefan Kristiansson wrote:
> This adds support for the VGA/LCD core available from OpenCores:
> http://opencores.org/project,vga_lcd
>
> The driver have been tested together with both OpenRISC and
> ARM (socfpga) processors.
>
> Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
If I'm not mistaken, this driver has been designed so that there can
only be one VGA/LCD core device on the system.
It would be better to get rid of those static structs, and have the
driver data per device as it should. That way the driver works even with
multiple VGA/LCD cores (although the video mode module option is a bit
odd in that case).
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
<linux-kernel@vger.kernel.org>, <linux-fbdev@vger.kernel.org>
Cc: <plagnioj@jcrosoft.com>
Subject: Re: [PATCH v4] video: add OpenCores VGA/LCD framebuffer driver
Date: Fri, 10 Jan 2014 14:08:27 +0200 [thread overview]
Message-ID: <52CFE2BB.8090004@ti.com> (raw)
In-Reply-To: <1385739911-6541-1-git-send-email-stefan.kristiansson@saunalahti.fi>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
Hi,
On 2013-11-29 17:45, Stefan Kristiansson wrote:
> This adds support for the VGA/LCD core available from OpenCores:
> http://opencores.org/project,vga_lcd
>
> The driver have been tested together with both OpenRISC and
> ARM (socfpga) processors.
>
> Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
If I'm not mistaken, this driver has been designed so that there can
only be one VGA/LCD core device on the system.
It would be better to get rid of those static structs, and have the
driver data per device as it should. That way the driver works even with
multiple VGA/LCD cores (although the video mode module option is a bit
odd in that case).
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2014-01-10 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 15:45 [PATCH v4] video: add OpenCores VGA/LCD framebuffer driver Stefan Kristiansson
2013-11-29 15:45 ` Stefan Kristiansson
2014-01-10 12:08 ` Tomi Valkeinen [this message]
2014-01-10 12:08 ` Tomi Valkeinen
2014-01-10 16:16 ` Stefan Kristiansson
2014-01-10 16:16 ` Stefan Kristiansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CFE2BB.8090004@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.