From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Eniac" Subject: passing smbios table from qemu Date: Mon, 6 Jan 2014 21:01:21 +0000 Message-ID: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2560261537247038096==" Return-path: Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "xen-devel@lists.xen.org" Cc: "Zhang, Eniac" List-Id: xen-devel@lists.xenproject.org --===============2560261537247038096== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57G4W3221americas_" --_000_3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57G4W3221americas_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi all, Qemu 1.6.1 allows us to passing multiple SMBIOS table to it using -smbios o= ption(s). However, I couldn't seem to see the table I passed into guest OS= . I used rwall under the windows and dmidecode under linux, they both retu= rns a fresh smbios table built in the hvmloader instead of the ones I pass = into qemu. I tried to figure out what's missing by digging into the code. To my surpr= ise, although qemu now can read and put multiple smbios tables in a nice st= ructure, that never gets used by hvmloader or seabios. I have looked from = Xen4.2.0 to Xen4.2.3, with Seabios up to 1.7.3. Question, am I missing anything, or this feature (passing smbios) is still = work in progress? Regards/Eniac --_000_3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57G4W3221americas_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi all,

Qemu 1.6.1 allows us to passing multiple SMBIOS tabl= e to it using -smbios option(s). However, I couldn’t seem to se= e the table I passed into guest OS. I used rwall under the windows an= d dmidecode under linux, they both returns a fresh smbios table built in the hvmloader instead of the ones I pass into qemu.<= o:p>

I tried to figure out what’s missing by diggin= g into the code. To my surprise, although qemu now can read and put m= ultiple smbios tables in a nice structure, that never gets used by hvmloade= r or seabios. I have looked from Xen4.2.0 to Xen4.2.3, with Seabios up to 1.7.3.

Question, am I missing anything, or this feature (pa= ssing smbios) is still work in progress?

Regards/Eniac

--_000_3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57G4W3221americas_-- --===============2560261537247038096== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2560261537247038096==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: passing smbios table from qemu Date: Tue, 7 Jan 2014 13:56:02 +0000 Message-ID: <1389102962.12612.19.camel@kazak.uk.xensource.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Zhang, Eniac" Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Mon, 2014-01-06 at 21:01 +0000, Zhang, Eniac wrote: > Question, am I missing anything, or this feature (passing smbios) is > still work in progress? Under Xen smbios tables are supplied via hvmloader, not via qemu. What tables and or values do you want to override/supply? I believe that libxc supports passing in extra smbios tables when building the guest (via struct xc_hvm_build_args.smbios_module) but nothing has been plumbed in to make use of this. I'm not aware of any on going work to plumb that stuff further up, e.g. to libxl and xl or other toolstacks. (I think the libxc functionality is only consumed by the XenClient toolstack). There is also some support in hvmloader for setting certain SMBIOS parameters via xenstore keys. See the varios HVM_XS_* in tools/firmware/hvmloader/smbios.c. It includes things like the system manufacturer, chassis number etc. Do either of those cover your use case? Are you interested in plumbing them up? Ian. From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Eniac" Subject: Re: passing smbios table from qemu Date: Wed, 8 Jan 2014 16:58:17 +0000 Message-ID: <3B22ECA2D19A3D408C83F4F15A9CB7D450762FED@G4W3221.americas.hpqcorp.net> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com>, <3B22ECA2D19A3D408C83F4F15A9CB7D45076233C@G4W3221.americas.hpqcorp.net> , <3B22ECA2D19A3D408C83F4F15A9CB7D450762410@G4W3221.americas.hpqcorp.net> <2559B97E2BCECA4BA2AF63DA8CF5C7200D095CD7@G1W3640.americas.hpqcorp.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1574490690870549404==" Return-path: In-Reply-To: <2559B97E2BCECA4BA2AF63DA8CF5C7200D095CD7@G1W3640.americas.hpqcorp.net> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Ian.Campbell@citrix.com" Cc: "Zhang, Eniac" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============1574490690870549404== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_3B22ECA2D19A3D408C83F4F15A9CB7D450762FEDG4W3221americas_" --_000_3B22ECA2D19A3D408C83F4F15A9CB7D450762FEDG4W3221americas_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Dear Ian, Thanks for the clarification. None of the things you mentioned addresses my needs where I wanted to pass = part of SMBIOS table to guest thus make it look more like the physical host= we are running on. I actually made it work by some extra code. The chang= e is small but I would like to have our corporate legal staff review it bef= ore releasing that to xen community. On top of that, I still doubt that who-else would be interest in this excep= t myself. After all, the essence of virtualization is to abstract physical= systems rather than trying to make guest looks similar to the host. Regards/Eniac -----Original Message----- From: Ian Campbell [mailto:Ian.Campbell@citrix.com] Sent: Tuesday, January 07, 2014 6:56 AM To: Zhang, Eniac Cc: xen-devel@lists.xen.org Subject: Re: [Xen-devel] passing smbios table from qemu On Mon, 2014-01-06 at 21:01 +0000, Zhang, Eniac wrote: > Question, am I missing anything, or this feature (passing smbios) is > still work in progress? Under Xen smbios tables are supplied via hvmloader, not via qemu. What tables and or values do you want to override/supply? I believe that libxc supports passing in extra smbios tables when building = the guest (via struct xc_hvm_build_args.smbios_module) but nothing has been= plumbed in to make use of this. I'm not aware of any on going work to plumb that stuff further up, e.g. to libxl and xl or other toolstacks. (I think the libxc functionality is on= ly consumed by the XenClient toolstack). There is also some support in hvmloader for setting certain SMBIOS paramete= rs via xenstore keys. See the varios HVM_XS_* in tools/firmware/hvmloader/s= mbios.c. It includes things like the system manufacturer, chassis number et= c. Do either of those cover your use case? Are you interested in plumbing them= up? Ian. --_000_3B22ECA2D19A3D408C83F4F15A9CB7D450762FEDG4W3221americas_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Dear Ian,

<= /p>

Thanks for the clarificat= ion.

<= /p>

None of the things you me= ntioned addresses my needs where I wanted= to pass part of SMBIOS table to guest thus make it look more lik= e the physical host we are running on.&nb= sp; I actually made it work by some extra cod= e. The change is small but I would like to have our corporate legal staff review it before releasing that to xen community.

<= /p>

On top of that, I still d= oubt that who-else would be interest in this except myself. After all= , the essence of virtualization is to abstract physical systems rather than trying to make guest looks similar to the host.

<= /p>

Regards/Eniac=

-----Original Message-----
From: Ian Campbell [mailto:Ian.C= ampbell@citrix.com]
Sent: Tuesday, January 07, 2014 6:56 AM
To: Zhang, Eniac
Cc: xen-devel@lists.xen.org<= br> Subject: Re: [Xen-devel] passing smbios table from qemu

On Mon, 2014-01-06 at 21:01 +0000, Zhang, Eniac wrote:

> Question, am I missing anything, or this feature (passing smbios) is <= br> > still work in progress?

Under Xen smbios tables are supplied via hvmloader, not via qemu.

What tables and or values do you want to override/supply?

I believe that libxc supports passing in extra smbios tables when building = the guest (via struct xc_hvm_build_args.smbios_module) but nothing has been= plumbed in to make use of this.

I'm not aware of any on going work to plumb that stuff further up, e.g.
to libxl and xl or other toolstacks. (I think the libxc functionality is on= ly consumed by the XenClient toolstack).

There is also some support in hvmloader for setting certain SMBIOS paramete= rs via xenstore keys. See the varios HVM_XS_* in tools/firmware/hvmloader/s= mbios.c. It includes things like the system manufacturer, chassis number et= c.

Do either of those cover your use case? Are you interested in plumbing them= up?

Ian.

--_000_3B22ECA2D19A3D408C83F4F15A9CB7D450762FEDG4W3221americas_-- --===============1574490690870549404== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1574490690870549404==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: passing smbios table from qemu Date: Wed, 8 Jan 2014 17:51:26 +0000 Message-ID: <1389203486.27473.11.camel@kazak.uk.xensource.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> , <3B22ECA2D19A3D408C83F4F15A9CB7D45076233C@G4W3221.americas.hpqcorp.net> , <3B22ECA2D19A3D408C83F4F15A9CB7D450762410@G4W3221.americas.hpqcorp.net> <2559B97E2BCECA4BA2AF63DA8CF5C7200D095CD7@G1W3640.americas.hpqcorp.net> <3B22ECA2D19A3D408C83F4F15A9CB7D450762FED@G4W3221.americas.hpqcorp.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <3B22ECA2D19A3D408C83F4F15A9CB7D450762FED@G4W3221.americas.hpqcorp.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Zhang, Eniac" Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Wed, 2014-01-08 at 16:58 +0000, Zhang, Eniac wrote: > None of the things you mentioned addresses my needs where I wanted to > passpartof SMBIOStable to guest thus make it look more like the > physical host we are running on. I thought that was why the code to let various bits of the tables be set from xenstore was for -- to allow the tools to propagate bits of host smbios tables. Is it just not covering some specific value you are interested in? > I actually made it work by some extra code. The change is small but > I would like to haveour corporate legal staffreview itbefore releasing > that to xen community. Understood. > On top of that, I still doubt that who-else would be interest in this > except myself. After all, the essence of virtualization is to > abstract physical systems rather than trying to make guest looks > similar to the host. As I say some of the existing code is there to serve this usecase, I don't think it is that weird, e.g. on the client end in particular. Ian,. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Philipson Subject: Re: passing smbios table from qemu Date: Wed, 8 Jan 2014 18:29:56 +0000 Message-ID: <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1389102962.12612.19.camel@kazak.uk.xensource.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , "Zhang, Eniac" Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org > -----Original Message----- > From: xen-devel-bounces@lists.xen.org [mailto:xen-devel- > bounces@lists.xen.org] On Behalf Of Ian Campbell > Sent: Tuesday, January 07, 2014 8:56 AM > To: Zhang, Eniac > Cc: xen-devel@lists.xen.org > Subject: Re: [Xen-devel] passing smbios table from qemu > > On Mon, 2014-01-06 at 21:01 +0000, Zhang, Eniac wrote: > > > Question, am I missing anything, or this feature (passing smbios) is > > still work in progress? > > Under Xen smbios tables are supplied via hvmloader, not via qemu. > > What tables and or values do you want to override/supply? > > I believe that libxc supports passing in extra smbios tables when > building the guest (via struct xc_hvm_build_args.smbios_module) but > nothing has been plumbed in to make use of this. > > I'm not aware of any on going work to plumb that stuff further up, e.g. > to libxl and xl or other toolstacks. (I think the libxc functionality is > only consumed by the XenClient toolstack). Just FYI, I did go back and add the support (and docs) for it in libxl. I did this after the first set of patches went in per someone's request (can't recall who it was at the moment). > > There is also some support in hvmloader for setting certain SMBIOS > parameters via xenstore keys. See the varios HVM_XS_* in > tools/firmware/hvmloader/smbios.c. It includes things like the system > manufacturer, chassis number etc. > > Do either of those cover your use case? Are you interested in plumbing > them up? > > Ian. > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > > ----- > No virus found in this message. > Checked by AVG - www.avg.com > Version: 2014.0.4259 / Virus Database: 3658/6979 - Release Date: > 01/06/14 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: passing smbios table from qemu Date: Thu, 9 Jan 2014 10:06:24 +0000 Message-ID: <1389261984.27473.46.camel@kazak.uk.xensource.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ross Philipson Cc: "Zhang, Eniac" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Wed, 2014-01-08 at 18:29 +0000, Ross Philipson wrote: > > -----Original Message----- > > From: xen-devel-bounces@lists.xen.org [mailto:xen-devel- > > bounces@lists.xen.org] On Behalf Of Ian Campbell > > Sent: Tuesday, January 07, 2014 8:56 AM > > To: Zhang, Eniac > > Cc: xen-devel@lists.xen.org > > Subject: Re: [Xen-devel] passing smbios table from qemu > > > > On Mon, 2014-01-06 at 21:01 +0000, Zhang, Eniac wrote: > > > > > Question, am I missing anything, or this feature (passing smbios) is > > > still work in progress? > > > > Under Xen smbios tables are supplied via hvmloader, not via qemu. > > > > What tables and or values do you want to override/supply? > > > > I believe that libxc supports passing in extra smbios tables when > > building the guest (via struct xc_hvm_build_args.smbios_module) but > > nothing has been plumbed in to make use of this. > > > > I'm not aware of any on going work to plumb that stuff further up, e.g. > > to libxl and xl or other toolstacks. (I think the libxc functionality is > > only consumed by the XenClient toolstack). > > Just FYI, I did go back and add the support (and docs) for it in > libxl. I did this after the first set of patches went in per someone's > request (can't recall who it was at the moment). Ah yes, here it is: smbios_firmware="STRING" Specify a path to a file that contains extra SMBIOS firmware structures to pass in to a guest. The file can contain a set DMTF predefined structures which will override the internal defaults. Not all predefined structures can be overridden, only the following types: 0, 1, 2, 3, 11, 22, 39. The file can also contain any number of vendor defined SMBIOS structures (type 128 - 255). Since SMBIOS structures do not present their overall size, each entry in the file must be preceded by a 32b integer indicating the size of the next structure. Did you not have a tool/library for helping to create such blobs somewhere? Or is my memory playing tricks? Ian. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Philipson Subject: Re: passing smbios table from qemu Date: Thu, 9 Jan 2014 09:46:59 -0500 Message-ID: <52CEB663.4070609@citrix.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> <1389261984.27473.46.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1389261984.27473.46.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "Zhang, Eniac" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 01/09/2014 05:06 AM, Ian Campbell wrote: > On Wed, 2014-01-08 at 18:29 +0000, Ross Philipson wrote: >>> -----Original Message----- >>> From: xen-devel-bounces@lists.xen.org [mailto:xen-devel- >>> bounces@lists.xen.org] On Behalf Of Ian Campbell >>> Sent: Tuesday, January 07, 2014 8:56 AM >>> To: Zhang, Eniac >>> Cc: xen-devel@lists.xen.org >>> Subject: Re: [Xen-devel] passing smbios table from qemu >>> >>> On Mon, 2014-01-06 at 21:01 +0000, Zhang, Eniac wrote: >>> >>>> Question, am I missing anything, or this feature (passing smbios) is >>>> still work in progress? >>> >>> Under Xen smbios tables are supplied via hvmloader, not via qemu. >>> >>> What tables and or values do you want to override/supply? >>> >>> I believe that libxc supports passing in extra smbios tables when >>> building the guest (via struct xc_hvm_build_args.smbios_module) but >>> nothing has been plumbed in to make use of this. >>> >>> I'm not aware of any on going work to plumb that stuff further up, e.g. >>> to libxl and xl or other toolstacks. (I think the libxc functionality is >>> only consumed by the XenClient toolstack). >> >> Just FYI, I did go back and add the support (and docs) for it in >> libxl. I did this after the first set of patches went in per someone's >> request (can't recall who it was at the moment). > > Ah yes, here it is: > smbios_firmware="STRING" > Specify a path to a file that contains extra SMBIOS firmware > structures to pass in to a guest. The file can contain a set DMTF > predefined structures which will override the internal defaults. > Not all predefined structures can be overridden, only the > following types: 0, 1, 2, 3, 11, 22, 39. The file can also contain > any number of vendor defined SMBIOS structures (type 128 - 255). > Since SMBIOS structures do not present their overall size, each > entry in the file must be preceded by a 32b integer indicating the > size of the next structure. > > Did you not have a tool/library for helping to create such blobs > somewhere? Or is my memory playing tricks? Your memory is intact; I did provide a helper library. I posted it as a tarball since I could not figure out where such a thing might live in the xen tree. I posted it twice - the second time with some fixes: http://lists.xen.org/archives/html/xen-devel/2013-03/msg01850.html > > Ian. > > > ----- > No virus found in this message. > Checked by AVG - www.avg.com > Version: 2014.0.4259 / Virus Database: 3658/6986 - Release Date: 01/08/14 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: passing smbios table from qemu Date: Thu, 9 Jan 2014 14:56:12 +0000 Message-ID: <1389279372.19805.18.camel@kazak.uk.xensource.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> <1389261984.27473.46.camel@kazak.uk.xensource.com> <52CEB663.4070609@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52CEB663.4070609@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ross Philipson Cc: "Zhang, Eniac" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Thu, 2014-01-09 at 09:46 -0500, Ross Philipson wrote: > On 01/09/2014 05:06 AM, Ian Campbell wrote: > > Did you not have a tool/library for helping to create such blobs > > somewhere? Or is my memory playing tricks? > > Your memory is intact; I did provide a helper library. I posted it as a > tarball since I could not figure out where such a thing might live in > the xen tree. I posted it twice - the second time with some fixes: > > http://lists.xen.org/archives/html/xen-devel/2013-03/msg01850.html Thanks! I went looking for a suitable wiki page to link this from, but didn't find one... Oh well, maybe next time I'll have enough memory to look in the archives... Ian. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: passing smbios table from qemu Date: Thu, 9 Jan 2014 14:00:50 -0500 Message-ID: <20140109190049.GB17806@pegasus.dumpdata.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> <1389261984.27473.46.camel@kazak.uk.xensource.com> <52CEB663.4070609@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <52CEB663.4070609@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ross Philipson Cc: "Zhang, Eniac" , Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Thu, Jan 09, 2014 at 09:46:59AM -0500, Ross Philipson wrote: > On 01/09/2014 05:06 AM, Ian Campbell wrote: > >On Wed, 2014-01-08 at 18:29 +0000, Ross Philipson wrote: > >>>-----Original Message----- > >>>From: xen-devel-bounces@lists.xen.org [mailto:xen-devel- > >>>bounces@lists.xen.org] On Behalf Of Ian Campbell > >>>Sent: Tuesday, January 07, 2014 8:56 AM > >>>To: Zhang, Eniac > >>>Cc: xen-devel@lists.xen.org > >>>Subject: Re: [Xen-devel] passing smbios table from qemu > >>> > >>>On Mon, 2014-01-06 at 21:01 +0000, Zhang, Eniac wrote: > >>> > >>>>Question, am I missing anything, or this feature (passing smbios) is > >>>>still work in progress? > >>> > >>>Under Xen smbios tables are supplied via hvmloader, not via qemu. > >>> > >>>What tables and or values do you want to override/supply? > >>> > >>>I believe that libxc supports passing in extra smbios tables when > >>>building the guest (via struct xc_hvm_build_args.smbios_module) but > >>>nothing has been plumbed in to make use of this. > >>> > >>>I'm not aware of any on going work to plumb that stuff further up, e.g. > >>>to libxl and xl or other toolstacks. (I think the libxc functionality is > >>>only consumed by the XenClient toolstack). > >> > >>Just FYI, I did go back and add the support (and docs) for it in > >>libxl. I did this after the first set of patches went in per someone's > >>request (can't recall who it was at the moment). > > > >Ah yes, here it is: > > smbios_firmware="STRING" > > Specify a path to a file that contains extra SMBIOS firmware > > structures to pass in to a guest. The file can contain a set DMTF > > predefined structures which will override the internal defaults. > > Not all predefined structures can be overridden, only the > > following types: 0, 1, 2, 3, 11, 22, 39. The file can also contain > > any number of vendor defined SMBIOS structures (type 128 - 255). > > Since SMBIOS structures do not present their overall size, each > > entry in the file must be preceded by a 32b integer indicating the > > size of the next structure. > > > >Did you not have a tool/library for helping to create such blobs > >somewhere? Or is my memory playing tricks? > > Your memory is intact; I did provide a helper library. I posted it > as a tarball since I could not figure out where such a thing might > live in the xen tree. I posted it twice - the second time with some > fixes: > > http://lists.xen.org/archives/html/xen-devel/2013-03/msg01850.html Would it make sense to try to have it as part of the Xen tree? It looks in good shape. > > > > > >Ian. > > > > > >----- > >No virus found in this message. > >Checked by AVG - www.avg.com > >Version: 2014.0.4259 / Virus Database: 3658/6986 - Release Date: 01/08/14 > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: passing smbios table from qemu Date: Fri, 10 Jan 2014 10:20:12 +0000 Message-ID: <1389349212.19142.21.camel@kazak.uk.xensource.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> <1389261984.27473.46.camel@kazak.uk.xensource.com> <52CEB663.4070609@citrix.com> <20140109190049.GB17806@pegasus.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140109190049.GB17806@pegasus.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: "Zhang, Eniac" , Ross Philipson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Thu, 2014-01-09 at 14:00 -0500, Konrad Rzeszutek Wilk wrote: > On Thu, Jan 09, 2014 at 09:46:59AM -0500, Ross Philipson wrote: > > Your memory is intact; I did provide a helper library. I posted it > > as a tarball since I could not figure out where such a thing might > > live in the xen tree. I posted it twice - the second time with some > > fixes: > > > > http://lists.xen.org/archives/html/xen-devel/2013-03/msg01850.html > > Would it make sense to try to have it as part of the Xen tree? > It looks in good shape. I think we considered this before, but I can't remember why we didn't (assuming we even explicitly decided that rather than just letting it slip through the cracks). Ian. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Philipson Subject: Re: passing smbios table from qemu Date: Fri, 10 Jan 2014 09:25:26 -0500 Message-ID: <52D002D6.7090306@citrix.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> <1389261984.27473.46.camel@kazak.uk.xensource.com> <52CEB663.4070609@citrix.com> <20140109190049.GB17806@pegasus.dumpdata.com> <1389349212.19142.21.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1389349212.19142.21.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" , "Zhang, Eniac" List-Id: xen-devel@lists.xenproject.org On 01/10/2014 05:20 AM, Ian Campbell wrote: > On Thu, 2014-01-09 at 14:00 -0500, Konrad Rzeszutek Wilk wrote: >> On Thu, Jan 09, 2014 at 09:46:59AM -0500, Ross Philipson wrote: > >>> Your memory is intact; I did provide a helper library. I posted it >>> as a tarball since I could not figure out where such a thing might >>> live in the xen tree. I posted it twice - the second time with some >>> fixes: >>> >>> http://lists.xen.org/archives/html/xen-devel/2013-03/msg01850.html >> >> Would it make sense to try to have it as part of the Xen tree? >> It looks in good shape. > > I think we considered this before, but I can't remember why we didn't > (assuming we even explicitly decided that rather than just letting it > slip through the cracks). It has been a while but yea, we did discuss putting it in the tools somewhere. I then went off and tried to find a reasonable place for it and could not. The last thing that happened was that I sent an email asking for suggestions, did not get any replies and then I got distracted (sorry 'bout that). So I guess that is the question: where to put it? Should it be merged into another lib or be brought in as a separate lib or utility? Thanks Ross > > Ian. > > > ----- > No virus found in this message. > Checked by AVG - www.avg.com > Version: 2014.0.4259 / Virus Database: 3658/6989 - Release Date: 01/09/14 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: passing smbios table from qemu Date: Fri, 10 Jan 2014 15:03:53 +0000 Message-ID: <1389366233.19142.60.camel@kazak.uk.xensource.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> <1389261984.27473.46.camel@kazak.uk.xensource.com> <52CEB663.4070609@citrix.com> <20140109190049.GB17806@pegasus.dumpdata.com> <1389349212.19142.21.camel@kazak.uk.xensource.com> <52D002D6.7090306@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52D002D6.7090306@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ross Philipson Cc: Ian Jackson , "xen-devel@lists.xen.org" , "Zhang, Eniac" List-Id: xen-devel@lists.xenproject.org On Fri, 2014-01-10 at 09:25 -0500, Ross Philipson wrote: > So I guess that is the question: where to put it? Should it be merged > into another lib or be brought in as a separate lib or utility? I guess the choices are libxc, libxl, libxlutils or an entirely new lib? At what level would we expect this to be used? Would it be internal to e.g. libxl (in which case libxc or libxl would be appropriate) or would toolstacks be expected to use it and pass the result to libxl? If that is the case then libxc is inappropriate (users of libxl are not supposed to have to deal with libxc directly). Fitting in with libxl proper would require the API to look a certain way (take a context etc), so perhaps libxlu would be more appropriate, alongside the disk syntax parser etc? Ian. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Philipson Subject: Re: passing smbios table from qemu Date: Fri, 10 Jan 2014 15:32:51 -0500 Message-ID: <52D058F3.5080504@citrix.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> <1389261984.27473.46.camel@kazak.uk.xensource.com> <52CEB663.4070609@citrix.com> <20140109190049.GB17806@pegasus.dumpdata.com> <1389349212.19142.21.camel@kazak.uk.xensource.com> <52D002D6.7090306@citrix.com> <1389366233.19142.60.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1389366233.19142.60.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , "xen-devel@lists.xen.org" , "Zhang, Eniac" List-Id: xen-devel@lists.xenproject.org On 01/10/2014 10:03 AM, Ian Campbell wrote: > On Fri, 2014-01-10 at 09:25 -0500, Ross Philipson wrote: >> So I guess that is the question: where to put it? Should it be merged >> into another lib or be brought in as a separate lib or utility? > > I guess the choices are libxc, libxl, libxlutils or an entirely new lib? > > At what level would we expect this to be used? Would it be internal to > e.g. libxl (in which case libxc or libxl would be appropriate) or would > toolstacks be expected to use it and pass the result to libxl? If that > is the case then libxc is inappropriate (users of libxl are not supposed > to have to deal with libxc directly). I don't think it would be internal to libxl. I think it would be used the second way you mention; toolstacks would use it and pass the results. The exact way it is used would be implementation specific. Files might need to be generated once, on every boot, before vms are started, etc. I did not think it belonged in either libxl/xc. > > Fitting in with libxl proper would require the API to look a certain way > (take a context etc), so perhaps libxlu would be more appropriate, > alongside the disk syntax parser etc? Possibly. I looked at that back then (and today again) and it seemed to all be related to parsing things into XLU_Config objects. I guess I did not have a good feel for what libxlu was supposed to be. If it is supposed to be a generic library of auxiliary toolstack functionality then I think it would be a good place. Thanks Ross > > Ian. > > > ----- > No virus found in this message. > Checked by AVG - www.avg.com > Version: 2014.0.4259 / Virus Database: 3658/6991 - Release Date: 01/10/14 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: passing smbios table from qemu Date: Mon, 13 Jan 2014 10:25:32 +0000 Message-ID: <1389608732.13654.5.camel@kazak.uk.xensource.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> <1389261984.27473.46.camel@kazak.uk.xensource.com> <52CEB663.4070609@citrix.com> <20140109190049.GB17806@pegasus.dumpdata.com> <1389349212.19142.21.camel@kazak.uk.xensource.com> <52D002D6.7090306@citrix.com> <1389366233.19142.60.camel@kazak.uk.xensource.com> <52D058F3.5080504@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52D058F3.5080504@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ross Philipson Cc: Ian Jackson , "xen-devel@lists.xen.org" , "Zhang, Eniac" List-Id: xen-devel@lists.xenproject.org On Fri, 2014-01-10 at 15:32 -0500, Ross Philipson wrote: > On 01/10/2014 10:03 AM, Ian Campbell wrote: > > Fitting in with libxl proper would require the API to look a certain way > > (take a context etc), so perhaps libxlu would be more appropriate, > > alongside the disk syntax parser etc? > > Possibly. I looked at that back then (and today again) and it seemed to > all be related to parsing things into XLU_Config objects. I guess I did > not have a good feel for what libxlu was supposed to be. If it is > supposed to be a generic library of auxiliary toolstack functionality > then I think it would be a good place. I think that (aux functionality) was the intention -- the fact that it is all parsing stuff right now is just a coincidence. (Ian J: right?) Ian. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: passing smbios table from qemu Date: Mon, 13 Jan 2014 11:31:55 +0000 Message-ID: <21203.52907.856721.125370@mariner.uk.xensource.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> <1389261984.27473.46.camel@kazak.uk.xensource.com> <52CEB663.4070609@citrix.com> <20140109190049.GB17806@pegasus.dumpdata.com> <1389349212.19142.21.camel@kazak.uk.xensource.com> <52D002D6.7090306@citrix.com> <1389366233.19142.60.camel@kazak.uk.xensource.com> <52D058F3.5080504@citrix.com> <1389608732.13654.5.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1389608732.13654.5.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" , "Zhang, Eniac" , Ross Philipson List-Id: xen-devel@lists.xenproject.org Ian Campbell writes ("Re: [Xen-devel] passing smbios table from qemu"): > On Fri, 2014-01-10 at 15:32 -0500, Ross Philipson wrote: > > On 01/10/2014 10:03 AM, Ian Campbell wrote: > > > Fitting in with libxl proper would require the API to look a certain way > > > (take a context etc), so perhaps libxlu would be more appropriate, > > > alongside the disk syntax parser etc? > > > > Possibly. I looked at that back then (and today again) and it seemed to > > all be related to parsing things into XLU_Config objects. I guess I did > > not have a good feel for what libxlu was supposed to be. If it is > > supposed to be a generic library of auxiliary toolstack functionality > > then I think it would be a good place. > > I think that (aux functionality) was the intention -- the fact that it > is all parsing stuff right now is just a coincidence. > > (Ian J: right?) Yes, that's right. Thanks, Ian. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Philipson Subject: Re: passing smbios table from qemu Date: Tue, 14 Jan 2014 10:21:54 -0500 Message-ID: <52D55612.8060501@citrix.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> <1389261984.27473.46.camel@kazak.uk.xensource.com> <52CEB663.4070609@citrix.com> <20140109190049.GB17806@pegasus.dumpdata.com> <1389349212.19142.21.camel@kazak.uk.xensource.com> <52D002D6.7090306@citrix.com> <1389366233.19142.60.camel@kazak.uk.xensource.com> <52D058F3.5080504@citrix.com> <1389608732.13654.5.camel@kazak.uk.xensource.com> <21203.52907.856721.125370@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21203.52907.856721.125370@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "xen-devel@lists.xen.org" , "Zhang, Eniac" , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 01/13/2014 06:31 AM, Ian Jackson wrote: > Ian Campbell writes ("Re: [Xen-devel] passing smbios table from qemu"): >> On Fri, 2014-01-10 at 15:32 -0500, Ross Philipson wrote: >>> On 01/10/2014 10:03 AM, Ian Campbell wrote: >>>> Fitting in with libxl proper would require the API to look a certain way >>>> (take a context etc), so perhaps libxlu would be more appropriate, >>>> alongside the disk syntax parser etc? >>> >>> Possibly. I looked at that back then (and today again) and it seemed to >>> all be related to parsing things into XLU_Config objects. I guess I did >>> not have a good feel for what libxlu was supposed to be. If it is >>> supposed to be a generic library of auxiliary toolstack functionality >>> then I think it would be a good place. >> >> I think that (aux functionality) was the intention -- the fact that it >> is all parsing stuff right now is just a coincidence. Ok then libxlu sounds like a reasonable place for this. I will submit a patch. >> >> (Ian J: right?) > > Yes, that's right. > > Thanks, > Ian. > > ----- > No virus found in this message. > Checked by AVG - www.avg.com > Version: 2014.0.4259 / Virus Database: 3658/6999 - Release Date: 01/13/14 > -- Ross Philipson From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: passing smbios table from qemu Date: Tue, 14 Jan 2014 15:23:50 +0000 Message-ID: <1389713030.12434.86.camel@kazak.uk.xensource.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> <1389261984.27473.46.camel@kazak.uk.xensource.com> <52CEB663.4070609@citrix.com> <20140109190049.GB17806@pegasus.dumpdata.com> <1389349212.19142.21.camel@kazak.uk.xensource.com> <52D002D6.7090306@citrix.com> <1389366233.19142.60.camel@kazak.uk.xensource.com> <52D058F3.5080504@citrix.com> <1389608732.13654.5.camel@kazak.uk.xensource.com> <21203.52907.856721.125370@mariner.uk.xensource.com> <52D55612.8060501@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52D55612.8060501@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ross Philipson Cc: "Zhang, Eniac" , "xen-devel@lists.xen.org" , Ian Jackson List-Id: xen-devel@lists.xenproject.org On Tue, 2014-01-14 at 10:21 -0500, Ross Philipson wrote: > On 01/13/2014 06:31 AM, Ian Jackson wrote: > > Ian Campbell writes ("Re: [Xen-devel] passing smbios table from qemu"): > >> On Fri, 2014-01-10 at 15:32 -0500, Ross Philipson wrote: > >>> On 01/10/2014 10:03 AM, Ian Campbell wrote: > >>>> Fitting in with libxl proper would require the API to look a certain way > >>>> (take a context etc), so perhaps libxlu would be more appropriate, > >>>> alongside the disk syntax parser etc? > >>> > >>> Possibly. I looked at that back then (and today again) and it seemed to > >>> all be related to parsing things into XLU_Config objects. I guess I did > >>> not have a good feel for what libxlu was supposed to be. If it is > >>> supposed to be a generic library of auxiliary toolstack functionality > >>> then I think it would be a good place. > >> > >> I think that (aux functionality) was the intention -- the fact that it > >> is all parsing stuff right now is just a coincidence. > > Ok then libxlu sounds like a reasonable place for this. I will submit a > patch. Thanks. It's probably a bit late to squeeze this in for 4.4, so you've got a little while until 4.5 development opens. Ian. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Philipson Subject: Re: passing smbios table from qemu Date: Tue, 14 Jan 2014 10:39:19 -0500 Message-ID: <52D55A27.4090103@citrix.com> References: <3B22ECA2D19A3D408C83F4F15A9CB7D45075EA57@G4W3221.americas.hpqcorp.net> <1389102962.12612.19.camel@kazak.uk.xensource.com> <92B37F2487AE0841841737618F25AC1A1918AABE@FTLPEX01CL03.citrite.net> <1389261984.27473.46.camel@kazak.uk.xensource.com> <52CEB663.4070609@citrix.com> <20140109190049.GB17806@pegasus.dumpdata.com> <1389349212.19142.21.camel@kazak.uk.xensource.com> <52D002D6.7090306@citrix.com> <1389366233.19142.60.camel@kazak.uk.xensource.com> <52D058F3.5080504@citrix.com> <1389608732.13654.5.camel@kazak.uk.xensource.com> <21203.52907.856721.125370@mariner.uk.xensource.com> <52D55612.8060501@citrix.com> <1389713030.12434.86.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1389713030.12434.86.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "Zhang, Eniac" , "xen-devel@lists.xen.org" , Ian Jackson List-Id: xen-devel@lists.xenproject.org On 01/14/2014 10:23 AM, Ian Campbell wrote: > On Tue, 2014-01-14 at 10:21 -0500, Ross Philipson wrote: >> On 01/13/2014 06:31 AM, Ian Jackson wrote: >>> Ian Campbell writes ("Re: [Xen-devel] passing smbios table from qemu"): >>>> On Fri, 2014-01-10 at 15:32 -0500, Ross Philipson wrote: >>>>> On 01/10/2014 10:03 AM, Ian Campbell wrote: >>>>>> Fitting in with libxl proper would require the API to look a certain way >>>>>> (take a context etc), so perhaps libxlu would be more appropriate, >>>>>> alongside the disk syntax parser etc? >>>>> >>>>> Possibly. I looked at that back then (and today again) and it seemed to >>>>> all be related to parsing things into XLU_Config objects. I guess I did >>>>> not have a good feel for what libxlu was supposed to be. If it is >>>>> supposed to be a generic library of auxiliary toolstack functionality >>>>> then I think it would be a good place. >>>> >>>> I think that (aux functionality) was the intention -- the fact that it >>>> is all parsing stuff right now is just a coincidence. >> >> Ok then libxlu sounds like a reasonable place for this. I will submit a >> patch. > > Thanks. It's probably a bit late to squeeze this in for 4.4, so you've > got a little while until 4.5 development opens. Right, I will shoot for 4.5 then - thanks. > > Ian. > > -- Ross Philipson