From: John Fastabend <john.r.fastabend@intel.com>
To: Jason Wang <jasowang@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, mst@redhat.com,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH net V3 1/2] macvlan: forbid L2 fowarding offload for macvtap
Date: Fri, 10 Jan 2014 09:39:41 -0800 [thread overview]
Message-ID: <52D0305D.2000801@intel.com> (raw)
In-Reply-To: <1389341906-2367-1-git-send-email-jasowang@redhat.com>
On 1/10/2014 12:18 AM, Jason Wang wrote:
> L2 fowarding offload will bypass the rx handler of real device. This will make
> the packet could not be forwarded to macvtap device. Another problem is the
> dev_hard_start_xmit() called for macvtap does not have any synchronization.
>
> Fix this by forbidding L2 forwarding for macvtap.
>
> Cc: John Fastabend <john.r.fastabend@intel.com>
> Cc: Neil Horman <nhorman@tuxdriver.com>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
Same thing here tested my l2 forwarding offload use cases
and they still work. Thanks! For net-next we can look at
getting macvtap to work correctly.
Acked-by: John Fastabend <john.r.fastabend@intel.com.com>
next prev parent reply other threads:[~2014-01-10 17:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 8:18 [PATCH net V3 1/2] macvlan: forbid L2 fowarding offload for macvtap Jason Wang
2014-01-10 8:18 ` [PATCH net V3 2/2] net: core: explicitly select a txq before doing l2 forwarding Jason Wang
2014-01-10 8:18 ` Jason Wang
2014-01-10 14:30 ` Neil Horman
2014-01-10 14:30 ` Neil Horman
2014-01-10 17:37 ` John Fastabend
2014-01-10 18:24 ` David Miller
2014-01-10 18:24 ` David Miller
2014-01-10 17:39 ` John Fastabend [this message]
2014-01-10 18:24 ` [PATCH net V3 1/2] macvlan: forbid L2 fowarding offload for macvtap David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D0305D.2000801@intel.com \
--to=john.r.fastabend@intel.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.