From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: Scrub heap pages during boot Date: Fri, 10 Jan 2014 17:57:50 +0000 Message-ID: <52D0349E.5070504@linaro.org> References: <1389324476-9158-1-git-send-email-julien.grall@linaro.org> <1389347521.19142.9.camel@kazak.uk.xensource.com> <52CFFA1C.7000500@linaro.org> <1389373745.6423.39.camel@kazak.uk.xensource.com> <1389376265.6423.46.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1W1gLD-00049B-CX for xen-devel@lists.xenproject.org; Fri, 10 Jan 2014 17:57:55 +0000 Received: by mail-ee0-f46.google.com with SMTP id d49so2061331eek.19 for ; Fri, 10 Jan 2014 09:57:53 -0800 (PST) In-Reply-To: <1389376265.6423.46.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com, patches@linaro.org List-Id: xen-devel@lists.xenproject.org On 01/10/2014 05:51 PM, Ian Campbell wrote: > On Fri, 2014-01-10 at 17:09 +0000, Ian Campbell wrote: >> On Fri, 2014-01-10 at 13:48 +0000, Julien Grall wrote: >>> >>> On 01/10/2014 09:52 AM, Ian Campbell wrote: >>>> On Fri, 2014-01-10 at 03:27 +0000, Julien Grall wrote: >>>>> Scrub heap pages was disabled because it was slow on the models. Now that Xen >>>>> supports real hardware, it's possible to enable by default scrubbing. >>>>> >>>>> Signed-off-by: Julien Grall >>>> >>>> Acked-by: Ian Campbell >>> >>> Thanks. >> >> Applied. >> >>>>> --- >>>>> This patch should go to Xen 4.4. It avoid to give non-cleared page to >>>>> a domain. >>>>> >>>>> The downside is it's now slow on models. >>>> >>>> There is a no-bootscrub command-line option which can be used in that >>>> case. Could you update the relevant model wiki pages to mention it >>>> please? >>> >>> I have updated the wiki page. >> >> Thanks. > > You made it say "comment out the code" rather than advising to use the > command line option like I suggested -- was that on purpose? > > Is something broken with the command line option? No, I thought we will need to create a command line. I will update the wiki page. -- Julien Grall