From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH v3 3/5] dbg_rw_guest_mem: Conditionally enable debug log output Date: Fri, 10 Jan 2014 17:08:21 -0500 Message-ID: <52D06F55.7050002@terremark.com> References: <1389140748-26524-1-git-send-email-dslutz@verizon.com> <1389140748-26524-4-git-send-email-dslutz@verizon.com> <1389177510.4883.11.camel@kazak.uk.xensource.com> <52CD60AA.9010607@terremark.com> <1389199626.4883.112.camel@kazak.uk.xensource.com> <20140108170442.GA75747@deinos.phlegethon.org> <1389203062.27473.8.camel@kazak.uk.xensource.com> <20140108163822.30b6f87a@mantra.us.oracle.com> <1389261548.27473.42.camel@kazak.uk.xensource.com> <52CEC978.7040705@terremark.com> <52CEDCD30200007800112096@nat28.tlf.novell.com> <52CEE2E2.2030501@terremark.com> <1389373999.6423.42.camel@kazak.uk.xensource.com> <52D062FE.5000803@terremark.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52D062FE.5000803@terremark.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Don Slutz Cc: Keir Fraser , Ian Campbell , Stefano Stabellini , George Dunlap , Tim Deegan , Ian Jackson , xen-devel@lists.xen.org, Jan Beulich List-Id: xen-devel@lists.xenproject.org On 01/10/14 16:15, Don Slutz wrote: > On 01/10/14 12:13, Ian Campbell wrote: >> On Thu, 2014-01-09 at 12:56 -0500, Don Slutz wrote: >>> On 01/09/14 11:30, Jan Beulich wrote: >>>>>>> On 09.01.14 at 17:08, Don Slutz wrote: >>>>> Based on Mukesh's statement, attached is the rebased version of >>>>> this patch >>>>> (labeled v3). I included Mukesh's ack. >>>> Unless this is meant just for reviewing purposes (albeit even then >>>> it's likely problematic), could you please get used to sending >>>> patch revisions with mail subjects (i.e. not retaining the prior >>>> version indicator), so there is a reasonable chance to reconstruct >>>> things by searching just the titles in a mail archive. (It's still >>>> fine - >>>> at least as far as I'm concerned - to reply to an earlier version, >>>> thus tying things into a single thread on the archive.) >>>> >>>> Jan >>>> >>> I will try to. I had not noticed this in the past. >> Thanks, as Jan says it is very confusing. >> >> If there are tools things outstanding in this series which should be for >> 4.4 then I don't know what is where or what has been acked. >> >> Please can resend whatever you think is outstanding for 4.4 as a fresh >> thread with a suitable vN larger than any of the ones mentioned in any >> of the replies here and with the acks collected. >> >> Ian. >> > Will do. I expect ~1 hour to rebase, build and quick test. > > -Don I have send out v4 of the rest. Adjusted this thread to v3. I did not include this one in the 4.4 because: 1) Is is debug logging. 2) not 100% sure on volatile, __read_mostly, __used , __used__, and maybe drop static. 3) Most developers cannot change dbg_debug value without a re-compile. And then volatile is not needed for them. So I think it is fine to delay until 4.5 is open for this. -Don Slutz