From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W28S1-0000p9-Og for qemu-devel@nongnu.org; Sat, 11 Jan 2014 18:58:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W28Rv-0008VB-PK for qemu-devel@nongnu.org; Sat, 11 Jan 2014 18:58:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46607) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W28Rv-0008V7-H5 for qemu-devel@nongnu.org; Sat, 11 Jan 2014 18:58:43 -0500 Message-ID: <52D1DAD6.8020007@redhat.com> Date: Sun, 12 Jan 2014 00:59:18 +0100 From: Max Reitz MIME-Version: 1.0 References: <1388950991-30105-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1388950991-30105-5-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1388950991-30105-5-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V9 4/8] qcow2: return int for qcow2_free_clusters() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com, peter.crosthwaite@xilinx.com, stefanha@redhat.com On 05.01.2014 20:43, Wenchao Xia wrote: > The return value can help caller check whether error happens, > and it does not need to have *errp since the return value already tips > what happend. > > Signed-off-by: Wenchao Xia > --- > block/qcow2-refcount.c | 8 +++++--- > block/qcow2.h | 6 +++--- > 2 files changed, 8 insertions(+), 6 deletions(-) I'm not sure if we actually need this since it's never really bad to have an error occur in qcow2_free_clusters(); at least, there's nothing the caller can do about that and it never blocks any subsequent operation, so most callers just don't care. But it won't hurt, either, so: Reviewed-by: Max Reitz