From: sourav <sourav.poddar-l0cyMroinI0@public.gmane.org>
To: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC][PATCH] spi: ti-qspi: Fixup driver name
Date: Sun, 12 Jan 2014 13:56:22 +0530 [thread overview]
Message-ID: <52D251AE.6080007@ti.com> (raw)
In-Reply-To: <1389510152.13361.4.camel@phoenix>
On Sunday 12 January 2014 12:32 PM, Axel Lin wrote:
> The driver name in current code looks like a compatible string which is not
> the naming convention for platform drivers.
> Fix it and also add modalias since this driver can be built as a module.
>
> Signed-off-by: Axel Lin<axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/spi/spi-ti-qspi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
> index 2a1ab49..3d09265 100644
> --- a/drivers/spi/spi-ti-qspi.c
> +++ b/drivers/spi/spi-ti-qspi.c
> @@ -567,7 +567,7 @@ static struct platform_driver ti_qspi_driver = {
> .probe = ti_qspi_probe,
> .remove = ti_qspi_remove,
> .driver = {
> - .name = "ti,dra7xxx-qspi",
> + .name = "ti-qspi",
> .owner = THIS_MODULE,
> .pm =&ti_qspi_pm_ops,
> .of_match_table = ti_qspi_match,
> @@ -579,3 +579,4 @@ module_platform_driver(ti_qspi_driver);
> MODULE_AUTHOR("Sourav Poddar<sourav.poddar-l0cyMroinI0@public.gmane.org>");
> MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("TI QSPI controller driver");
> +MODULE_ALIAS("platform:ti-qspi");
Acked-by: Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-12 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-12 7:02 [RFC][PATCH] spi: ti-qspi: Fixup driver name Axel Lin
2014-01-12 8:26 ` sourav [this message]
2014-01-13 10:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D251AE.6080007@ti.com \
--to=sourav.poddar-l0cymroini0@public.gmane.org \
--cc=axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.