From mboxrd@z Thu Jan  1 00:00:00 1970
From: Prabhakar Kushwaha <prabhakar@freescale.com>
Date: Mon, 13 Jan 2014 11:13:17 +0530
Subject: [U-Boot] [PATCH] powerpc:Rename CONFIG_PBLRCW_CONFIG &
	CONFIG_SYS_FSL_PBL_PBI
In-Reply-To: <20140113053254.D9DF83821EB@gemini.denx.de>
References: <1389587917-10324-1-git-send-email-prabhakar@freescale.com>
	<20140113053254.D9DF83821EB@gemini.denx.de>
Message-ID: <52D37CF5.2090100@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Thanks Wolfgang for reviewing this patch.
Please find my reply in-lined


On 1/13/2014 11:02 AM, Wolfgang Denk wrote:
> Dear Prabhakar Kushwaha,
>
> In message <1389587917-10324-1-git-send-email-prabhakar@freescale.com> you wrote:
>> Rename CONFIG_PBLRCW_CONFIG and CONFIG_PBLRCW_CONFIG.
> What is the reason for the reenaming?  Especially, why changing from
> CONFIG_ to CONFIG_SYS_ ?

CONFIG_PBLRCW_CONFIG has 2 CONFIG. it is slightly confusing.

Reason for moving CONFIG_ to CONFIG_SYS:  These defines enables of 
adding RCW(power on reset configuration) and
PBI(pre boot loader commands) in u-boot image. These information will be 
used by SoC hardware for NAND, SD, SPI boot.
As these configuration will be used by SoC hardware. I thought of adding 
CONFIG_SYS.

Please let me know, if I need to rename it again.

>> Also add their details in README.
> ...
>
>> +		CONFIG_SYS_FSL_PBL_PBI
>> +		CONFIG_SYS_FSL_PBL_RCW
>> +		Provides a tool to build boot Image for PBL(Pre boot loader)
>> +		Here PBL can be used to load some instructions and/or data for
>> +		pre-initialization.
>> +		Define both configs to enable above feature.
> Hm...This does not really explain what CONFIG_SYS_FSL_PBL_PBI or
> CONFIG_SYS_FSL_PBL_RCW actually means.
>
>
You are right. Let me correct it.

Thanks,
Prabhakar