From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2fVI-0004p2-Ro for qemu-devel@nongnu.org; Mon, 13 Jan 2014 06:16:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2fVC-0005MC-T2 for qemu-devel@nongnu.org; Mon, 13 Jan 2014 06:16:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2fVC-0005Gg-Kf for qemu-devel@nongnu.org; Mon, 13 Jan 2014 06:16:18 -0500 Message-ID: <52D3CAFB.8030003@redhat.com> Date: Mon, 13 Jan 2014 12:16:11 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1389302063-2432-1-git-send-email-thomaswk@google.com> <1389302063-2432-2-git-send-email-thomaswk@google.com> <52CFEF3C.5000403@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] KVM: Retry KVM_CREATE_VM on EINTR or EAGAIN List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Knych Cc: Andrea Arcangeli , David Turner , qemu-devel@nongnu.org, gleb@redhat.com Il 10/01/2014 23:15, Tom Knych ha scritto: > I'll flip the conditional check > > So I traced thru the code and the one path I saw returning EINTR was: > > kvm_dev_ioctl_create_vm -> kvm_create_vm -> kvm_init_mmu_notifier -> > mmu_notifier_register -> do_mmu_notifier_register -> mm_take_all_locks > > Which checks if any signals have been raised while it was attaining > locks and returns EINTR. > > Going thru my logs - all of my errors actually are EINTRs I'll remove > the EAGAIN Andrea, what do you think here? Is it intended that kvm_init_mmu_notifier return an EINTR that percolates up to userspace? Paolo