From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Steven Noonan <steven@uplinklabs.net>,
"Noonan, Steven" <snoonan@amazon.com>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
Brad Smith <brad@comstyle.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags
Date: Mon, 13 Jan 2014 12:53:32 +0100 [thread overview]
Message-ID: <52D3D3BC.1050009@redhat.com> (raw)
In-Reply-To: <52D0F6E6.9090502@weilnetz.de>
Il 11/01/2014 08:46, Stefan Weil ha scritto:
> Hi Steven,
>
> --disable-stack-protector would also be useful for platforms which make
> debugging of executables with stack protection difficult. When I must
> debug Windows executables, I always disable stack protection, because
> otherwise the stack back traces are unreadable.
>
> So, for MinGW it might be reasonable to set the default to no stack
> protection if --enable-debug is selected. This requires some
> modifications in your patch.
>
> # Don't set it to "yes" initially:
> stack_protector=""
>
> # Do the compile test if it is not "no":
> if test "$stack_protector" != "no"; then
Apart from this little detail, the patch looks good.
Steven, please resend the patch as a top-level message with the patch
inline rather than attached. This is needed so that Anthony's script
will pick it up. Including these changes would be nice too.
Paolo
> The usual logic is do nothing if the user says "no". Run the compile
> tests otherwise. Show an error message if the compile tests fail and the
> user said "yes". See the code which handles $pie for an example.
>
> Please send your next patch inline - this makes it easier to add comments.
>
> Best regards
>
> Stefan
>
next prev parent reply other threads:[~2014-01-13 11:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 21:55 [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags Steven Noonan
2014-01-09 21:55 ` [Qemu-devel] [PATCH 2/3] virtfs-proxy-helper.c: fix compile error Steven Noonan
2014-01-09 21:55 ` [Qemu-devel] [PATCH 3/3] Makefile: add bios-256k.bin to BLOBS Steven Noonan
2014-01-09 23:27 ` Peter Maydell
2014-01-09 23:30 ` Noonan, Steven
2014-01-10 9:12 ` Markus Armbruster
2014-01-09 22:30 ` [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags Peter Maydell
2014-01-09 22:40 ` Paolo Bonzini
2014-01-09 23:18 ` Brad Smith
2014-01-09 23:31 ` Noonan, Steven
2014-01-11 2:36 ` Noonan, Steven
2014-01-11 7:46 ` Stefan Weil
2014-01-13 11:53 ` Paolo Bonzini [this message]
2014-01-13 20:00 ` [Qemu-devel] [PATCH] " Steven Noonan
2014-01-13 20:27 ` Stefan Weil
2014-01-13 20:38 ` Noonan, Steven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D3D3BC.1050009@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@amazon.com \
--cc=brad@comstyle.com \
--cc=qemu-devel@nongnu.org \
--cc=snoonan@amazon.com \
--cc=steven@uplinklabs.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.