From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v3 01/16] common/symbols: Export hypervisor symbols to PV guest Date: Mon, 13 Jan 2014 10:00:18 -0500 Message-ID: <52D3FF82.7020005@oracle.com> References: <1389036295-3877-1-git-send-email-boris.ostrovsky@oracle.com> <1389036295-3877-2-git-send-email-boris.ostrovsky@oracle.com> <52D03580020000780011298A@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1W2izb-0006Y8-Je for xen-devel@lists.xenproject.org; Mon, 13 Jan 2014 14:59:55 +0000 In-Reply-To: <52D03580020000780011298A@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: keir@xen.org, suravee.suthikulpanit@amd.com, andrew.cooper3@citrix.com, eddie.dong@intel.com, dietmar.hahn@ts.fujitsu.com, jun.nakajima@intel.com, xen-devel List-Id: xen-devel@lists.xenproject.org On 01/10/2014 12:01 PM, Jan Beulich wrote: > >> --- a/xen/arch/x86/x86_64/platform_hypercall.c >> +++ b/xen/arch/x86/x86_64/platform_hypercall.c >> @@ -32,6 +32,8 @@ CHECK_pf_pcpu_version; >> CHECK_pf_enter_acpi_sleep; >> #undef xen_pf_enter_acpi_sleep >> >> +#define xenpf_symdata compat_pf_symdata >> + > This should be done like other cases (see context above): Add a > CHECK_ invocation, which in turn requires an entry in include/xlat.lst. Based on your comment to my attempt to patch compat.h, is this really needed? Since xenpf_symdata contains a handle we shouldn't subject it to checking, should we? -boris