Re: [PATCH v2 0/2] Support to tune governor in run time

[Eduardo Valentin <eduardo.valentin-l0cyMroinI0@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]

Wei,

Thanks for your patches. Please help me out to properly understand your
intentions here.

On 13-01-2014 07:17, Wei Ni wrote:
> This serie can support to turn governor for thermal zone in
> run time.

Can you please explain why this is needed? Are you facing troubles with
current way to switch governors? If yes, can you please report them?

> Adds avaiable_policies attribute, so the user can get available
> governor policies and change te governor to a new one.

OK. This one I understand the need and you are explaining its motivation.

> Adds thermal_update_governor() function, so the thermal platform
> driver can use it to update governor.

Here I cannot see why the platform driver would need to update a
governor, instead of a zone. Platform drivers are not supposed to be
aware of governors. For updating a zone we already have an API for that,
please check documentation.

> 
> Changes from v1:
> 1. split avaiable_policies part to the "patch 1/2", and add document
> for it.
> 2. add document for the thermal_update_governor.
> 
> Wei Ni (2):
>   thermal: add available policies attribut
>   thermal: add interface to support tune governor in run-time
> 
>  Documentation/thermal/sysfs-api.txt |   11 ++++
>  drivers/thermal/thermal_core.c      |  105 ++++++++++++++++++++++++++++++++---
>  include/linux/thermal.h             |   12 ++++
>  3 files changed, 119 insertions(+), 9 deletions(-)
> 


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]