From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44694)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <romain.naour@openwide.fr>) id 1W2rIA-0002uh-Vt
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 18:51:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <romain.naour@openwide.fr>) id 1W2rI4-0005Yd-Q7
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 18:51:38 -0500
Received: from zimbra3.corp.accelance.fr ([213.162.49.233]:49908)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <romain.naour@openwide.fr>) id 1W2rI4-0005YX-KH
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 18:51:32 -0500
Message-ID: <52D47B02.6080905@openwide.fr>
Date: Tue, 14 Jan 2014 00:47:14 +0100
From: Romain Naour <romain.naour@openwide.fr>
MIME-Version: 1.0
References: <1389652389-22241-1-git-send-email-romain.naour@openwide.fr>
	<1389652389-22241-2-git-send-email-romain.naour@openwide.fr>
	<52D46C6D.8070300@redhat.com>
In-Reply-To: <52D46C6D.8070300@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/1] genius: add genius serial mouse
	emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org

Hi,

Thanks for review.

Le 13/01/2014 23:45, Eric Blake a =C3=A9crit :
> On 01/13/2014 03:33 PM, Romain Naour wrote:
>> This patch adds the emulation for a serial Genius mouse using
>> Mouse Systems protocol (5bytes).
>> This protocol is compatible with most 3-button serial mouse.
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>>   backends/Makefile.objs |   2 +-
>>   backends/gnmouse.c     | 339 +++++++++++++++++++++++++++++++++++++++=
++++++++++
>>   include/sysemu/char.h  |   3 +
>>   qapi-schema.json       |   1 +
>>   qemu-char.c            |   4 +
>>   qemu-options.hx        |  10 ++
>>   6 files changed, 358 insertions(+), 1 deletion(-)
>>   create mode 100644 backends/gnmouse.c
>> +++ b/backends/gnmouse.c
>> @@ -0,0 +1,339 @@
>> +/*
>> + * QEMU Genius GM-6 serial mouse emulation
>> + *
>> + * Adapted from msmouse
>> + *
>> + * Copyright (c) 2012 Romain Naour
> It is now 2014.
Fixed
>
>
>> +++ b/qapi-schema.json
>> @@ -3617,6 +3617,7 @@
>>                                          'null'   : 'ChardevDummy',
>>                                          'mux'    : 'ChardevMux',
>>                                          'msmouse': 'ChardevDummy',
>> +                                       'gnmouse': 'ChardevDummy',
>>                                          'braille': 'ChardevDummy',
>>                                          'stdio'  : 'ChardevStdio',
>>                                          'console': 'ChardevDummy',
> Ideally, you should also document that this branch was not always
> available in the union (I was expecting to see a doc line with '(since
> 2.0)' somewhere in the patch); but looking at the existing schema,
> you're just copying bad practice of adding to an already
> under-documented union.
>

You mean something like that ?
##
# @ChardevBackendKind:
#
# A union referencing different chardev backend configuration' info.
#
# Since: 1.4
#
# gnmouse backend since: 2.0
##
{ 'union': 'ChardevBackend', 'data': { 'file'   : 'ChardevFile',
[snip]

I will resend a v2 tomorrow.

Best regards,
Romain Naour