Re: [PATCH] md/raid5: Add compensation in sysfs for raid456.

[Michael Tokarev <mjt@tls.msk.ru>]

14.01.2014 09:40, majianpeng wrote:
> For non-fullstripe-write, raid456 need read some old data no matter how
> rcw or rmw. We use compensation to recored the value about the
> additional read-data.The unit of compenstaion is PAGE_SIZE.
> Using the formula compensation*PAGE_SIZE/write_count_for_md, we can know
> the efficiency.Using this we can tune the write mode to get the best
> efficiency.

Just a very small nitpick:

> --- a/drivers/md/raid5.h
> +++ b/drivers/md/raid5.h
> @@ -494,6 +494,11 @@ struct r5conf {
>  	struct r5worker_group	*worker_groups;
>  	int			group_cnt;
>  	int			worker_cnt_per_group;
> +
> +	/*For non-fullstripe-write, it need read some data

Missing space in the comment ;)

/mjt