From: Andrzej Hajda <a.hajda@samsung.com>
To: randy <lxr1234@hotmail.com>, Kamil Debski <k.debski@samsung.com>,
linux-media@vger.kernel.org
Cc: kyungmin.park@samsung.com
Subject: Re: using MFC memory to memery encoder, start stream and queue order problem
Date: Tue, 14 Jan 2014 11:29:13 +0100 [thread overview]
Message-ID: <52D51179.8030102@samsung.com> (raw)
In-Reply-To: <BLU0-SMTP183F0EEECCB365900DE2315ADBF0@phx.gbl>
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
On 01/14/2014 06:17 AM, randy wrote:
> Yes, it make encoder work. But sadness ./mfc-encode -m /dev/video1 -c
> h264,header_mode=1 -d 1 will still output a zero demo.out without
> header-mode or set it to zero will works.
> What is the problem?
It seems infradead repo is not synchronized with our internal repo.
Please apply attached patch.
Regards
Andrzej
[-- Attachment #2: 0001-Do-not-stop-encoding-after-empty-buffers.patch --]
[-- Type: text/x-patch, Size: 1126 bytes --]
>From bccf89a62a2e45cd45f4bf5d4adff9ec8a16b3bd Mon Sep 17 00:00:00 2001
From: Andrzej Hajda <a.hajda@samsung.com>
Date: Mon, 20 May 2013 09:24:23 +0200
Subject: [PATCH] Do not stop encoding after empty buffers
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
v4l2-mfc-encoder/func_dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/v4l2-mfc-encoder/func_dev.c b/v4l2-mfc-encoder/func_dev.c
index c3fff54..3cddef1 100644
--- a/v4l2-mfc-encoder/func_dev.c
+++ b/v4l2-mfc-encoder/func_dev.c
@@ -76,13 +76,13 @@ int func_deq_buf(struct io_dev *dev, enum io_dir dir)
for (i = 0; i < bufs->nplanes; ++i)
bufs->bytesused[bufs->nplanes * idx + i] = lens[i];
- dbg("Dequeued buffer %d/%d from %d:%d", idx, bufs->count, dev->fd, dir);
+ dbg("Dequeued buffer %d/%d from %d:%d ret=%d", idx, bufs->count, dev->fd, dir, ret);
--dev->io[dir].nbufs;
++dev->io[dir].counter;
- if (ret <= 0 || (dev->io[dir].limit &&
+ if (ret < 0 || (dev->io[dir].limit &&
dev->io[dir].limit <= dev->io[dir].counter)) {
dev->io[dir].state = FS_END;
dbg("End on %d:%d", dev->fd, dir);
--
1.8.3.2
next prev parent reply other threads:[~2014-01-14 10:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 11:35 using MFC memory to memery encoder, start stream and queue order problem randy
2014-01-02 12:29 ` Kamil Debski
[not found] ` <BLU0-SMTP266BE9BC66B254061740251ADCB0@phx.gbl>
[not found] ` <02c801cf07ba$8518f2f0$8f4ad8d0$%debski@samsung.com>
2014-01-02 14:03 ` randy
2014-01-03 8:15 ` randy
2014-01-03 8:15 ` randy
2014-01-03 15:16 ` randy
2014-01-08 14:42 ` Kamil Debski
2014-01-08 15:44 ` randy
[not found] ` <52CD725E.5060903@hotmail.com>
2014-01-10 9:15 ` randy
2014-01-10 11:13 ` Andrzej Hajda
2014-01-10 15:23 ` randy
2014-01-13 10:15 ` Andrzej Hajda
2014-01-13 11:18 ` Andrzej Hajda
2014-01-13 15:44 ` randy
2014-01-13 16:18 ` Kamil Debski
2014-01-14 5:17 ` randy
2014-01-14 10:29 ` Andrzej Hajda [this message]
2014-01-14 16:50 ` randy
2014-01-15 7:08 ` Andrzej Hajda
2014-01-15 15:50 ` randy
2014-01-16 12:37 ` Andrzej Hajda
2014-01-16 19:30 ` randy
2014-01-16 20:10 ` randy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D51179.8030102@samsung.com \
--to=a.hajda@samsung.com \
--cc=k.debski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=lxr1234@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.