From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Aaron Brown <aaron.f.brown@intel.com>, davem@davemloft.net
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next 5/6] i40e: trivial cleanup
Date: Tue, 14 Jan 2014 18:22:14 +0400 [thread overview]
Message-ID: <52D54816.7010403@cogentembedded.com> (raw)
In-Reply-To: <1389689394-22369-6-git-send-email-aaron.f.brown@intel.com>
Hello.
On 14-01-2014 12:49, Aaron Brown wrote:
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Remove some un-necessary parenthesis.
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
> Signed-off-by: Aaron Brown <aaron.f.brown@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c b/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c
> index 101ed41..d5d98fe 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c
> @@ -485,8 +485,7 @@ i40e_status i40e_configure_lan_hmc(struct i40e_hw *hw,
> /* Make one big object, a single SD */
> info.count = 1;
> ret_code = i40e_create_lan_hmc_object(hw, &info);
> - if ((ret_code) &&
> - (model == I40E_HMC_MODEL_DIRECT_PREFERRED))
> + if (ret_code && (model == I40E_HMC_MODEL_DIRECT_PREFERRED))
Parens around == are also unnecessary, if you're at it.
WBR, Sergei
next prev parent reply other threads:[~2014-01-14 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 8:49 [net-next 0/6] Intel Wired LAN Driver Updates Aaron Brown
2014-01-14 8:49 ` [net-next 1/6] i40e: remove extra register write Aaron Brown
2014-01-14 8:49 ` [net-next 2/6] i40e: associate VMDq queue with VM type Aaron Brown
2014-01-14 8:49 ` [net-next 3/6] i40e: make message meaningful Aaron Brown
2014-01-14 8:49 ` [net-next 4/6] i40e: whitespace fixes Aaron Brown
2014-01-14 8:49 ` [net-next 5/6] i40e: trivial cleanup Aaron Brown
2014-01-14 14:22 ` Sergei Shtylyov [this message]
2014-01-14 8:49 ` [net-next 6/6] i40e: Bump version number Aaron Brown
2014-01-15 2:56 ` [net-next 0/6] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D54816.7010403@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=aaron.f.brown@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.