From: Eric Blake <eblake@redhat.com>
To: William Dauchy <william@gandi.net>, qemu-devel@nongnu.org
Cc: Mark McLoughlin <markmc@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Laszlo Ersek <lersek@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tap: add the possibility to specify a tap prefix
Date: Tue, 14 Jan 2014 10:54:06 -0700 [thread overview]
Message-ID: <52D579BE.3080209@redhat.com> (raw)
In-Reply-To: <1389719733-7689-1-git-send-email-william@gandi.net>
[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]
On 01/14/2014 10:15 AM, William Dauchy wrote:
> this will permit to specify an interface prefix to the tap instead of the
> default one ("tap")
> this functionnality is useful when you need an easy way to find the
s/functionnality/functionality/
> interfaces attached to a given virtual machine
>
> +++ b/qapi-schema.json
> @@ -3028,7 +3028,8 @@
> { 'type': 'NetdevBridgeOptions',
> 'data': {
> '*br': 'str',
> - '*helper': 'str' } }
> + '*helper': 'str',
> + '*prefix': 'str'} }
Need to document the new field, including when it was added. Something
like:
# @NetdevBridgeOptions
#
# Connect a host TAP network interface to a host bridge device.
#
# @br: #optional bridge name
#
# @helper: #optional command to execute to configure bridge
#
# @prefix: #optional prefix to use in naming the bridge, default
# "tap" (since 2.0)
#
# Since 1.2
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2014-01-14 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 17:15 [Qemu-devel] [PATCH] tap: add the possibility to specify a tap prefix William Dauchy
2014-01-14 17:31 ` Paolo Bonzini
2014-01-14 17:40 ` William Dauchy
2014-01-14 18:24 ` Paolo Bonzini
2014-01-14 18:35 ` William Dauchy
2014-01-14 17:54 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D579BE.3080209@redhat.com \
--to=eblake@redhat.com \
--cc=jasowang@redhat.com \
--cc=lersek@redhat.com \
--cc=markmc@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=william@gandi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.