From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] DRA7: add ABB setup for MPU voltage domain
Date: Tue, 14 Jan 2014 14:06:07 -0500 [thread overview]
Message-ID: <52D58A9F.3060807@ti.com> (raw)
In-Reply-To: <1389724049-486-1-git-send-email-nm@ti.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/14/2014 01:27 PM, Nishanth Menon wrote:
> Patch adds modification to shared omap5 abb_setup() function, and
> proper registers definitions needed for ABB setup sequence. ABB is
> initialized for MPU voltage domain at OPP_NOM.
>
> Signed-off-by: Nishanth Menon <nm@ti.com> ---
>
> arch/arm/cpu/armv7/omap5/abb.c | 13 ++++++++++---
> arch/arm/cpu/armv7/omap5/prcm-regs.c | 8 ++++++++
> arch/arm/include/asm/arch-omap5/omap.h | 2 ++ 3 files changed,
> 20 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/omap5/abb.c
> b/arch/arm/cpu/armv7/omap5/abb.c index 31b6795..3bf8897 100644 ---
> a/arch/arm/cpu/armv7/omap5/abb.c +++
> b/arch/arm/cpu/armv7/omap5/abb.c @@ -28,18 +28,25 @@ s8
> abb_setup_ldovbb(u32 fuse, u32 ldovbb) { u32 vset; + u32
> fuse_enable_mask = OMAP5_ABB_FUSE_ENABLE_MASK; + u32 fuse_vset_mask
> = OMAP5_ABB_FUSE_VSET_MASK;
My only concern, which I know the answer to I think, is shouldn't we
just have no default values here, and case in the right one for
omap5/dra74x and then dra72x in the future, etc, etc. But we don't
know enough really to know if future SoCs will need a different
statement here, so it's good enough for now.
Reviewed-by: Tom Rini <trini@ti.com>
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJS1YqfAAoJENk4IS6UOR1WG6YP/3p2A28HH96gnagf/Rd64OKS
TpHF9bduHMyiu1BBSfoYuw2pWAhVrnTCTyhFRy6P+xFcU6+V7k+IK8D4CjOTdvvL
udgY5fm9tYBJvr8j3GRE5VLoBo/tXFkeKkEhhXh5tNJ0ag5KmKiHqF/0zWkJmj0Y
YRmKtrRudl29Ot2vX+zStg/0cdJm37e9/0VDMJnoM+Sc06jlc3MLulh2c+D23gkO
IxSdAFHVlFn2YHoxYlE6Vhys49op6Wr41QryxRoLvzSRoTj80oJq9+rMLWul2jpA
mjCsslUdOMGm7WaipcjulBTZvLV3Qz1XNgCwUdidBXrpQxhe2VmkTMGzyU49gAC+
QrT+wgXWTKpAIsvLIRZJQ9GJ3I9ZnDrHwRw4mbUX++ey5fwahR7DtafT2DgRxRwb
zLU0JpCBh2W98sTzNBfuGda3kYVDoNWu4nGZDB3H2wSn1r+dFNbQPmyWqAzMdFYa
aN9G+GeunOi0sU5W9pCXXMbjjA3Iq/SE0zUNqERPOoBusCrUpzo0u6n64iFGfq8i
r0EM6Lf5OxCyvqGdUbuDwe1D/fKceInqFglVuFppz87dRunTbU0gr5iGw29i5nkX
iSaSoaGHlOlJhF9x5lr2cyTpxdNO6SYsgjr6d57VP8KPs0BMosVQoQ9N+3Y4SwIa
S2gO/eIMTP9oA+3PcUPY
=v4DC
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-01-14 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 18:27 [U-Boot] [PATCH] DRA7: add ABB setup for MPU voltage domain Nishanth Menon
2014-01-14 19:06 ` Tom Rini [this message]
2014-01-24 20:19 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D58A9F.3060807@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.