From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Vince Bridgers <vbridgers2013@gmail.com>, netdev@vger.kernel.org
Cc: peppe.cavallaro@st.com, rayagond@vayavyalabs.com
Subject: Re: [PATCH net-next] stmmac: Add vlan rx for better GRO performance.
Date: Tue, 14 Jan 2014 22:14:09 +0300 [thread overview]
Message-ID: <52D58C81.802@cogentembedded.com> (raw)
In-Reply-To: <1389720846-6543-1-git-send-email-vbridgers2013@gmail.com>
Hello.
On 01/14/2014 08:34 PM, Vince Bridgers wrote:
> GRO requires VLANs to be removed before aggregation can occur.
> The Synopsys EMAC does not strip VLAN tags so this must be
> done by the driver.
> Signed-off-by: Vince Bridgers <vbridgers2013@gmail.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index b8e3a4c..e3ff84e 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -1951,6 +1951,22 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev)
> return NETDEV_TX_OK;
> }
>
> +static inline void stmmac_rx_vlan(struct net_device *dev, struct sk_buff *skb)
> +{
> + struct ethhdr *ehdr;
> + u16 vlanid;
Empty line after declarations wouldn't hurt.
> + if ((dev->features & NETIF_F_HW_VLAN_CTAG_RX) ==
> + NETIF_F_HW_VLAN_CTAG_RX &&
Line should start right below the second paren on the previousl line.
> + !__vlan_get_tag(skb, &vlanid)) {
This one too.
WBR, Sergei
prev parent reply other threads:[~2014-01-14 18:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 17:34 [PATCH net-next] stmmac: Add vlan rx for better GRO performance Vince Bridgers
2014-01-14 18:12 ` Stephen Hemminger
2014-01-14 19:14 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D58C81.802@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rayagond@vayavyalabs.com \
--cc=vbridgers2013@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.