From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeroen Hofstee Date: Tue, 14 Jan 2014 21:56:07 +0100 Subject: [U-Boot] [PATCH] nand: fix reading after switching ecc In-Reply-To: <1389732072.24905.109.camel@snotra.buserror.net> References: <1389447588-17529-1-git-send-email-jeroen@myspectrum.nl> <20980858CB6D3A4BAE95CA194937D5E73EA61001@DBDE04.ent.ti.com> <1389637125.24905.32.camel@snotra.buserror.net> <52D599DE.1000806@myspectrum.nl> <1389730875.24905.107.camel@snotra.buserror.net> <52D5A04D.8090407@myspectrum.nl> <1389732072.24905.109.camel@snotra.buserror.net> Message-ID: <52D5A467.7060209@myspectrum.nl> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/14/2014 09:41 PM, Scott Wood wrote: > On Tue, 2014-01-14 at 21:38 +0100, Jeroen Hofstee wrote: >> On 01/14/2014 09:21 PM, Scott Wood wrote: >>> All the other cleanup required to change ECC modes is handled by the >>> OMAP driver; why shouldn't this be as well? >> >> If there are more architectures, who think it is brilliant to switch ecc >> it will become a mesh if not coped with in general. And yes omap might >> be the exception for now, so lets put it there. > Perhaps, but solving it in general should not happen via changes like > this, but rather some sort of reset function that gives you a clean > slate. > I have no problem with a function call to nand_base resetting this flag, at least nand_base keeps in control of its own flag. I'll send you a patch for it. Regards, Jeroen